Hi Daniel, On Wed, Oct 19, 2011 at 10:53 PM, Daniel Juyung Seo <[email protected]> wrote: > Hello, > Talking about fixing indentation and removing wrong whitespaces, I've > been learned to do that from this mailing list when I started > uploading patches. I got reviewed and was requested to fix indentation > and remove trailing whitespaces. Of course, that's normal because to > new code has to be clean. > Anyhow, that's what I learned from here. So this became so normal to > me and others like hermet. I feel like it's my habit and if I see ugly > formatted code, I'd really love to fix them. > In my case when I work on a code, I fix indentation and whitespaces > first then apply my patch.
I think it's ok to do so, but add another step to your work flow: - Check in the log who introduced that white space or wrong indentation and spank him at #edevelop. Next time it happens to the same person, spank him twice and so on. Maybe after 10 times the person will be bothered enough to fix his editor :-) Regards, Lucas De Marchi ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Ciosco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
