SeoZ, you definitely need a lock, so somebody could not access your TODO list.
or..
Set a deadly trap there to blow someone away when he open your TODO list. :p
------------------------------------
Let's run together for the best moment!
-Regards, Hermet-
-----Original Message-----
From: "Enlightenment SVN"<no-re...@enlightenment.org>
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-21(금) 10:49:16
Subject: E SVN: discomfitor IN trunk: devs/seoz elementary/src/lib
Log:
remove gross genlistitemmoved function thingy and implement smart cb
also removed relevant item on TODO
Author: discomfitor
Date: 2011-10-20 18:49:15 -0700 (Thu, 20 Oct 2011)
New Revision: 64222
Trac: http://trac.enlightenment.org/e/changeset/64222
Modified:
trunk/devs/seoz/TODO trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_genlist.c
Modified: trunk/devs/seoz/TODO
===================================================================
--- trunk/devs/seoz/TODO 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/devs/seoz/TODO 2011-10-21 01:49:15 UTC (rev 64222)
@@ -4,7 +4,6 @@
[High] Enhance elm_genlist_height_for_width_mode_set() API.
[High] Revise Sohyun's genlist-entry patch.
- Enhance compress mode. Merge styles and call signals.
- - Changed "moved" item class function to smart callback.
- Merge _item_move_after/before().
- Fix reorder bug when the window edge is going out of the screen.
- Check elm_genlist_item_sorted_insert() API with group index, expandable list
and etc.
Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-21 01:49:15 UTC (rev 64222)
@@ -18082,6 +18082,7 @@
* pinched out. "- @c multi,pinch,in" - This is called when the genlist is
* multi-touch pinched in.
* - @c "swipe" - This is called when the genlist is swiped.
+ * - @c "moved" - This is called when a genlist item is moved.
* - @c "language,changed" - This is called when the program's language is
* changed.
*
@@ -18123,7 +18124,6 @@
typedef Evas_Object *(*Elm_Genlist_Item_Icon_Get_Cb) (void *data, Evas_Object
*obj, const char *part); /**< Icon fetching class function for genlist item
classes. */
typedef Eina_Bool (*Elm_Genlist_Item_State_Get_Cb) (void *data, Evas_Object
*obj, const char *part); /**< State fetching class function for genlist item
classes. */
typedef void (*Elm_Genlist_Item_Del_Cb) (void *data, Evas_Object *obj);
/**< Deletion class function for genlist item classes. */
- typedef void (*GenlistItemMovedFunc) (Evas_Object *obj, Elm_Genlist_Item
*item, Elm_Genlist_Item *rel_item, Eina_Bool move_after); /** TODO: remove this
by SeoZ **/
typedef char *(*GenlistItemLabelGetFunc) (void *data, Evas_Object *obj, const
char *part) EINA_DEPRECATED; /** DEPRECATED. Use Elm_Genlist_Item_Label_Get_Cb
instead. */
typedef Evas_Object *(*GenlistItemIconGetFunc) (void *data, Evas_Object *obj,
const char *part) EINA_DEPRECATED; /** DEPRECATED. Use
Elm_Genlist_Item_Icon_Get_Cb instead. */
@@ -18149,7 +18149,6 @@
Elm_Genlist_Item_Icon_Get_Cb icon_get; /**< Icon fetching class function
for genlist item classes. */
Elm_Genlist_Item_State_Get_Cb state_get; /**< State fetching class function
for genlist item classes. */
Elm_Genlist_Item_Del_Cb del; /**< Deletion class function for genlist item
classes. */
- GenlistItemMovedFunc moved; // TODO: do not use this. change this to smart
callback.
} func;
const char *mode_item_style;
};
Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:39:14 UTC (rev 64221)
+++ trunk/elementary/src/lib/elm_genlist.c 2011-10-21 01:49:15 UTC (rev 64222)
@@ -276,6 +276,7 @@
static const char SIG_MULTI_PINCH_OUT[] = "multi,pinch,out";
static const char SIG_MULTI_PINCH_IN[] = "multi,pinch,in";
static const char SIG_SWIPE[] = "swipe";
+static const char SIG_MOVED[] = "moved";
static const Evas_Smart_Cb_Description _signals[] = {
{SIG_CLICKED_DOUBLE, ""},
@@ -314,6 +315,7 @@
{SIG_MULTI_PINCH_OUT, ""},
{SIG_MULTI_PINCH_IN, ""},
{SIG_SWIPE, ""},
+ {SIG_MOVED, ""},
{NULL, NULL}
};
@@ -3474,9 +3476,7 @@
if (after->group_item) it->group_item = after->group_item;
_item_queue(it->wd, it);
- // TODO: change this to smart callback
- if (it->itc->func.moved)
- it->itc->func.moved(WIDGET(it), it, after, EINA_TRUE);
+ evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it);
}
static void
@@ -3494,9 +3494,7 @@
if (before->group_item) it->group_item = before->group_item;
_item_queue(it->wd, it);
- // TODO: change this to smart callback
- if (it->itc->func.moved)
- it->itc->func.moved(WIDGET(it), it, before, EINA_FALSE);
+ evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it);
}
EAPI Elm_Genlist_Item *
------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
