On 31/10/11 16:14, Cedric BAIL wrote: > Let me grumbl a little ! You should never again commit a patch that > does change indentation and behaviour at the same time. It make it > almost impossible to understand what is going on ! I can't review your > change without reading the code once the patch is applied and trying > to understand what change you did. That's very very bad.
Please consider reverting this patch, in case this patch will ever insert bugs it'll be terribly annoying to review it in the future. Reverting and committing cleaner split patches is preferable. -- Tom. ------------------------------------------------------------------------------ Get your Android app more play: Bring it to the BlackBerry PlayBook in minutes. BlackBerry App World™ now supports Android™ Apps for the BlackBerry® PlayBook™. Discover just how easy and simple it is! http://p.sf.net/sfu/android-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
