On Mon, Oct 31, 2011 at 3:49 PM, Kim Yunhan <spb...@gmail.com> wrote:
> Yes!
>
> I empathized what you worry about.
> At the first time, I tried to set this option at the initialization time in
> ecore_con_url.
> Then as you mentioned, no more propagation is occurred! :'-(
> So I looked around more deeply, then I change that this code is called at
> its finalization time as you seen in patch file.
> And to conclude, the progress is working!!
Oh, I missed that information, so sounds interesting to test then. I
can't at the moment, but as you have already investigated the problem
I just pointed, sounds good to go in svn then.
> On Mon, Oct 31, 2011 at 11:31 PM, Cedric BAIL <cedric.b...@free.fr> wrote:
>
>> On Mon, Oct 31, 2011 at 3:15 PM, Kim Yunhan <spb...@gmail.com> wrote:
>> > Ooops. I forgot to attach patch file. :-)
>> >
>> > On Mon, Oct 31, 2011 at 11:13 PM, Kim Yunhan <spb...@gmail.com> wrote:
>> >
>> >>
>> >> Hello.
>> >>
>> >> When I tested with elementary map, there is too many logs on console.
>> >> It makes me difficult to distinguish normal logs that I want to debug.
>> :'-(
>> >> It's libcurl's internal log for representing progress bar like this.
>> >>
>> >> -----
>> >> downloaded : 343 / 363
>> >> % Total % Received % Xferd Average Speed Time Time Time
>> >> Current
>> >> Dload Upload Total Spent Left
>> >> Speed
>> >> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> >> 0
>> >> downloaded : 343 / 362
>> >> % Total % Received % Xferd Average Speed Time Time Time
>> >> Current
>> >> Dload Upload Total Spent Left
>> >> Speed
>> >> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> >> 0
>> >> downloaded : 343 / 361
>> >> % Total % Received % Xferd Average Speed Time Time Time
>> >> Current
>> >> Dload Upload Total Spent Left
>> >> Speed
>> >> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> >> 0
>> >> downloaded : 344 / 365
>> >> downloaded : 345 / 365
>> >> downloaded : 346 / 365
>> >> downloaded : 347 / 365
>> >> -----
>> >>
>> >> So, I want to remove this log.
>> >> And I look around ecore_con_url's code.
>> >> Then I found solution for it.
>> >>
>> >> Index: src/lib/ecore_con/ecore_con_url.c
>> >> ===================================================================
>> >> --- src/lib/ecore_con/ecore_con_url.c (revision 64559)
>> >> +++ src/lib/ecore_con/ecore_con_url.c (working copy)
>> >> @@ -355,6 +355,7 @@
>> >> // FIXME: For an unknown reason, progress continue to arrive
>> >> after destruction
>> >> // this prevent any further call to the callback.
>> >> curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
>> >> NULL);
>> >> + curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
>> >> EINA_TRUE);
>> >>
>> >> if (url_con->active)
>> >> {
>> >>
>> >>
>> >> When ecore_con_url goes to finalize, ecore_con_url remove its own
>> progress
>> >> function from libcurl.
>> >> But final progress function is called in libcurl, and if there is no
>> >> progress function libcurl print out internal progress log message.
>> >> Anyway as you seen above, it's useless!!
>> >> So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
>> >> out no more progress log.
>> >>
>> >> Please review this simple patch, and commit in SVN.
>>
>> I think I already saw that patch, it did go in and was reverted,
>> because when you set noprogress, you don't receive progress
>> information and you can't propagate a progress event. Result you won't
>> be able to update a progress bar during download. It's super annoying,
>> I agree, but I never saw a patch that make this progress feature work
>> without the printf storm.
>> So if the progress is working, what I doubt, this patch could go in,
>> if not, it won't.
>> --
>> Cedric BAIL
>>
>>
>> ------------------------------------------------------------------------------
>> Get your Android app more play: Bring it to the BlackBerry PlayBook
>> in minutes. BlackBerry App World™ now supports Android™ Apps
>> for the BlackBerry® PlayBook™. Discover just how easy and simple
>> it is! http://p.sf.net/sfu/android-dev2dev
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> ------------------------------------------------------------------------------
> Get your Android app more play: Bring it to the BlackBerry PlayBook
> in minutes. BlackBerry App World™ now supports Android™ Apps
> for the BlackBerry® PlayBook™. Discover just how easy and simple
> it is! http://p.sf.net/sfu/android-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
--
Cedric BAIL
------------------------------------------------------------------------------
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
