On Sat, 5 Nov 2011 12:30:17 +0100 (CET) Vincent Torri <[email protected]> said:
> > > On Sat, 5 Nov 2011, Carsten Haitzler (The Rasterman) wrote: > > > On Sat, 5 Nov 2011 00:25:25 +0100 (CET) Vincent Torri <[email protected]> > > said: > > > >> > >> > >> On Fri, 4 Nov 2011, Enlightenment SVN wrote: > >> > >>> Log: > >>> fix a few warnings i get on 64bit than didnt pop up on 32, revert edje > >>> module load api break -back to eina_bool return. add some @sinces even > >>> if there are no docs. > >>> > >>> > >>> > >>> Author: raster > >>> Date: 2011-11-04 16:19:14 -0700 (Fri, 04 Nov 2011) > >>> New Revision: 64751 > >>> Trac: http://trac.enlightenment.org/e/changeset/64751 > >>> > >>> Modified: > >>> trunk/edje/src/bin/edje_multisense_convert.c trunk/edje/src/lib/Edje.h > >>> trunk/edje/src/lib/edje_module.c trunk/edje/src/lib/edje_multisense.c > >>> trunk/edje/src/lib/edje_private.h > >>> trunk/edje/src/modules/eet_snd_reader/eet_snd_reader.c > >>> > >>> Modified: trunk/edje/src/bin/edje_multisense_convert.c > >>> =================================================================== > >>> --- trunk/edje/src/bin/edje_multisense_convert.c 2011-11-04 > >>> 22:42:41 UTC (rev 64750) +++ trunk/edje/src/bin/edje_multisense_convert.c > >>> 2011-11-04 23:19:14 UTC (rev 64751) @@ -156,7 +156,7 @@ > >>> if (ok) > >>> { > >>> init_status = FLAC__stream_encoder_init_file(encoder, snd_path, > >>> NULL, > >>> - (void *) > >>> (total_samples)); > >>> + (void *)(long) > >>> (total_samples)); > >> > >> with such casts, i'll have problems on Windows 64 bits, as on that > >> platform, long if 4 bytes long and not 8 > > > > it will work fine - it'll just complain. total_samples is an int anyway and > > value won't exceed 32bits... :) it's be broken on 32bit machines then if it > > would... :) > > why not making total_sample as a size_t ? because a single 32bit unsigned int can hold enough for a sample @ 44.1khz that goes for 23hrs... that would mean the wav file would be (for stereo, 16bit) about 16gb of data... frankly... eet will run out of room as it's limited to 2gb in size due to using signed 32bit offsets... basically.. it doesn't matter. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
