On Fri, Nov 4, 2011 at 1:01 PM, Enlightenment SVN <no-re...@enlightenment.org> wrote: > Log: > Fix review comments from enlightenment-devel. Thanks to discomfitor and > demarchi. > > Signed-off-by: Sanjeev BA <iamsanj...@gmail.com> > > Author: sanjeev > Date: 2011-11-04 08:01:34 -0700 (Fri, 04 Nov 2011) > New Revision: 64737 > Trac: http://trac.enlightenment.org/e/changeset/64737 > > Modified: > trunk/PROTO/elev8/src/bin/dbus_library.cc trunk/e_dbus/ChangeLog > trunk/e_dbus/src/lib/dbus/E_DBus.h trunk/e_dbus/src/lib/dbus/e_dbus.c > > Modified: trunk/PROTO/elev8/src/bin/dbus_library.cc > =================================================================== > --- trunk/PROTO/elev8/src/bin/dbus_library.cc 2011-11-04 15:01:27 UTC (rev > 64736) > +++ trunk/PROTO/elev8/src/bin/dbus_library.cc 2011-11-04 15:01:34 UTC (rev > 64737) > @@ -24,13 +24,15 @@ > String::Utf8Value method(args[3]->ToString()); > fprintf(stderr, "%s-%s-%s-%s\n", *service, *path, *interface, > *method); > > - DBusConnection *conn = e_dbus_conn_object_get(dbus->conn); > + DBusConnection *conn; > DBusError error; > DBusMessage *message; > DBusMessage *reply; > int reply_timeout; > int value; > > + conn = e_dbus_connection_dbus_connection_get(dbus->conn); > +
Although I said the function you did was similar to this one, I also noted that you shouldn't export the internals. I'm not convinced yet you really need this. Maybe you need to extend e_dbus to fit your needs for js. Lucas De Marchi ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
