On Sun, 6 Nov 2011 12:21:42 +0900 Bluezery <[email protected]> said:
also in svn. thanks!
> Dear all
>
> _ecore_file_download_curl() does not check return value of even if
> ecore_con_url_get(), it can be failed.
> I add a simple error checking.
> Please review this patch.
>
>
> Index: src/lib/ecore_file/ecore_file_download.c
> ===================================================================
> --- src/lib/ecore_file/ecore_file_download.c (리비전 64791)
> +++ src/lib/ecore_file/ecore_file_download.c (작업 사본)
> @@ -369,7 +369,15 @@ _ecore_file_download_curl(const char *ur
> job->progress_cb = progress_cb;
> _job_list = eina_list_append(_job_list, job);
>
> - ecore_con_url_get(job->url_con);
> + if (!ecore_con_url_get(job->url_con))
> + {
> + ecore_con_url_free(job->url_con);
> + _job_list = eina_list_remove(_job_list, job);
> + fclose(job->file);
> + free(job->dst);
> + free(job);
> + return NULL;
> + }
>
> return job;
> }
>
>
> Thanks,
> Kim.
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
