On Sun, 6 Nov 2011 07:36:39 +0100 (CET) Vincent Torri <vto...@univ-evry.fr> said:
already did chlog. are you crazy? backporting to 1.0 2 weeks before 1.1? hell no. waste of time. > changelog > backport to 1.0 > > Vincent > > On Sat, 5 Nov 2011, Enlightenment SVN wrote: > > > Log: > > From: Bluezery <ohpo...@gmail.com> > > Subject: [E-devel] [ecore_file] Check a return value of > > ecore_con_url_get() > > > > _ecore_file_download_curl() does not check return value of even if > > ecore_con_url_get(), it can be failed. > > I add a simple error checking. > > Please review this patch. > > > > > > > > Author: raster > > Date: 2011-11-05 23:14:31 -0700 (Sat, 05 Nov 2011) > > New Revision: 64795 > > Trac: http://trac.enlightenment.org/e/changeset/64795 > > > > Modified: > > trunk/ecore/src/lib/ecore_file/ecore_file_download.c > > > > Modified: trunk/ecore/src/lib/ecore_file/ecore_file_download.c > > =================================================================== > > --- trunk/ecore/src/lib/ecore_file/ecore_file_download.c 2011-11-06 > > 06:11:57 UTC (rev 64794) +++ > > trunk/ecore/src/lib/ecore_file/ecore_file_download.c 2011-11-06 > > 06:14:31 UTC (rev 64795) @@ -369,7 +369,15 @@ job->progress_cb = > > progress_cb; _job_list = eina_list_append(_job_list, job); > > > > - ecore_con_url_get(job->url_con); > > + if (!ecore_con_url_get(job->url_con)) > > + { > > + ecore_con_url_free(job->url_con); > > + _job_list = eina_list_remove(_job_list, job); > > + fclose(job->file); > > + free(job->dst); > > + free(job); > > + return NULL; > > + } > > > > return job; > > } > > > > > > ------------------------------------------------------------------------------ > > RSA(R) Conference 2012 > > Save $700 by Nov 18 > > Register now > > http://p.sf.net/sfu/rsa-sfdev2dev1 > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Save $700 by Nov 18 > Register now > http://p.sf.net/sfu/rsa-sfdev2dev1 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
