fine. in svn - 65069
Thank you so much.
------------------------------------
-Regards, Hermet-
-----Original Message-----
From: "Bluezery"<ohpo...@gmail.com>
To: "Enlightenment developer
list"<enlightenment-devel@lists.sourceforge.net>
Cc:
Sent: 11-11-11(금) 13:32:04
Subject: [E-devel] [Patch][elm_map] Bug fix: use safe iterator instead
Hi,
There are bugs that map removes list elements when using
EINA_LIST_FOREACH or EINA_LIST_REVERSE_FOREACH.
We should use EINA_LIST_FOREACH_SAFE or EINA_LIST_REVERSE_FOREACH_SAFE
instead for above case.
Please review belows
Index: src/lib/elm_map.c
===================================================================
--- src/lib/elm_map.c (리비전 65041)
+++ src/lib/elm_map.c (작업 사본)
@@ -1240,7 +1240,7 @@ _process_download_list(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
Widget_Data *wd = elm_widget_data_get(obj);
- Eina_List *l;
+ Eina_List *l, *ll;
Evas_Coord ox, oy, ow, oh, cvx, cvy, cvw, cvh, tx, ty, gw, gh, xx,
yy, ww, hh;
Grid_Item *gi;
@@ -1250,7 +1250,7 @@ _process_download_list(Evas_Object *obj)
gw = wd->size.w;
gh = wd->size.h;
- EINA_LIST_FOREACH(wd->download_list, l, gi)
+ EINA_LIST_FOREACH_SAFE(wd->download_list, l, ll, gi)
{
xx = gi->out.x;
yy = gi->out.y;
@@ -1279,7 +1279,7 @@ _process_download_list(Evas_Object *obj)
}
}
- EINA_LIST_REVERSE_FOREACH(wd->download_list, l, gi)
+ EINA_LIST_REVERSE_FOREACH_SAFE(wd->download_list, l, ll, gi)
{
if (gi->wd->download_num >= MAX_CONCURRENT_DOWNLOAD)
break;
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
