On Fri, 11 Nov 2011, Christopher Michael wrote:
> On 11/11/11 13:51, Enlightenment SVN wrote: >> Log: >> Ecore: Fix warning: large integer implicitly truncated to unsigned type >> inecore_x/xcb >> >> xcb_get_property_unchecked() requires an uint32_t as last parameter, so >> use >> UINT_MAX instead of LONG_MAX >> >> Patch from OpenBSD via Jonathan Armani >> >> >> Author: caro >> Date: 2011-11-11 10:51:53 -0800 (Fri, 11 Nov 2011) >> New Revision: 65073 >> Trac: http://trac.enlightenment.org/e/changeset/65073 >> >> Modified: >> trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_mwm.c >> trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_window_prop.c >> >> Modified: trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_mwm.c >> =================================================================== >> --- trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_mwm.c 2011-11-11 18:11:10 UTC >> (rev 65072) >> +++ trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_mwm.c 2011-11-11 18:51:53 UTC >> (rev 65073) >> @@ -63,7 +63,7 @@ >> cookie = >> xcb_get_property_unchecked(_ecore_xcb_conn, 0, win, >> ECORE_X_ATOM_MOTIF_WM_HINTS, >> - ECORE_X_ATOM_MOTIF_WM_HINTS, 0, LONG_MAX); >> + ECORE_X_ATOM_MOTIF_WM_HINTS, 0, UINT_MAX); >> reply = xcb_get_property_reply(_ecore_xcb_conn, cookie, NULL); >> if (!reply) return EINA_FALSE; >> if ((reply->format != 32) || (reply->value_len == 0)) >> >> Modified: trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_window_prop.c >> =================================================================== >> --- trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_window_prop.c 2011-11-11 >> 18:11:10 UTC (rev 65072) >> +++ trunk/ecore/src/lib/ecore_x/xcb/ecore_xcb_window_prop.c 2011-11-11 >> 18:51:53 UTC (rev 65073) >> @@ -405,7 +405,7 @@ >> >> cookie = >> xcb_get_property_unchecked(_ecore_xcb_conn, 0, win, >> - property, type, 0, LONG_MAX); >> + property, type, 0, UINT_MAX); >> reply = xcb_get_property_reply(_ecore_xcb_conn, cookie, NULL); >> if (!reply) return 0; >> if ((reply->format != size) || (reply->value_len == 0)) >> >> > > I have no problems with these changes, so not trying to start any flame > wars here !! but I do have a question ... What list are these patches > being sent to ?? because I did not see these come across the e-dev list, > and am just wondering if I am missing a list where I should be > subscribed to. private discussion on #e.fr with OpenBSD guys. it's faster than mail Vincent ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
