On Fri, 11 Nov 2011, Kim Woelders wrote:

> On Fri, 11 Nov 2011 20:43:04 +0100, Enlightenment SVN
> <no-re...@enlightenment.org> wrote:
>
>> Log:
>> Ecore_X: Fix array problem for 64-bit (unsigned long vs unsigned int).
>>   Thanks vtorri ;)
>>
>> Author:       devilhorns
>> Date:         2011-11-11 11:43:04 -0800 (Fri, 11 Nov 2011)
>> New Revision: 65076
>> Trac:         http://trac.enlightenment.org/e/changeset/65076
>>
>> Modified:
>>   trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c
>>
>> Modified: trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c
>> ===================================================================
>> --- trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c   2011-11-11
>> 19:12:36 UTC (rev 65075)
>> +++ trunk/ecore/src/lib/ecore_x/xlib/ecore_x_window_prop.c   2011-11-11
>> 19:43:04 UTC (rev 65076)
>> @@ -131,7 +131,7 @@
>>               return -1;
>>            }
>>          for (i = 0; i < num_ret; i++)
>> -          val[i] = ((unsigned long *)prop_ret)[i];
>> +          val[i] = ((unsigned int *)prop_ret)[i];
>>          num = num_ret;
>>          *plst = val;
>>       }
>>
> This "fix" is incorrect - man XGetWindowProperty.

then val is wrong

Vincent

>
> ... and if it weren't there are four more occurrences of ((unsigned long
> *)prop_ret)[i] in the file.
>
> /Kim
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Save $700 by Nov 18
> Register now
> http://p.sf.net/sfu/rsa-sfdev2dev1
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to