On Thu, 24 Nov 2011 11:12:06 +0900 Jaehwan Kim <jaehwan.kim....@gmail.com> said:
> 2011년 11월 24일 목요일에 Carsten Haitzler님이 작성: > > > On Wed, 23 Nov 2011 10:32:51 -0200 Iván Briano (Sachiel) < > > sachi...@gmail.com <javascript:;>> > > said: > > > > > 2011/11/23 Enlightenment SVN <no-re...@enlightenment.org <javascript:;> > > >: > > > > Log: > > > > aaah allow type to be set on group inherit or part inherit... you just > > > > really shouldnt set it to a different type as its not very sensible. > > > > > > > > > > > > > > > > Author: raster > > > > Date: 2011-11-23 02:38:43 -0800 (Wed, 23 Nov 2011) > > > > New Revision: 65534 > > > > Trac: http://trac.enlightenment.org/e/changeset/65534 > > > > > > > > Modified: > > > > trunk/edje/src/bin/edje_cc_handlers.c > > > > > > > > Modified: trunk/edje/src/bin/edje_cc_handlers.c > > > > =================================================================== > > > > --- trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23 08:49:47 UTC > > > > (rev 65533) +++ trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23 > > > > 10:38:43 UTC (rev 65534) @@ -2965,13 +2965,6 @@ > > > > "EXTERNAL", EDJE_PART_TYPE_EXTERNAL, > > > > "PROXY", EDJE_PART_TYPE_PROXY, > > > > NULL); > > > > - > > > > - if (current_part->default_desc || current_part->other.desc_count > > > 0) > > > > - { > > > > - ERR("%s: Error. parse error %s:%i. You can't change the part > > type > > > > in inherited group. (part: %s)", > > > > - progname, file_in, line - 1, current_part->name); > > > > - exit(-1); > > > > - } > > > > } > > > > > > > > > > Can't we check if the type doesn't match and give an error in that case? > > > > we can... except this would break the intial type setting as the struct is > > newly alloced with 0's all thru... and so u couldnt know the difference > > between > > initial set of type and a later change in type. :) we'd need to go add more > > info/fllags and what not to know its been inherited etc. > > > > > It needs to remove old description and alloc new description, > because the part has different description structure as type. > I'm working for this job. I'll upload the patch. yeah - so right now its just a bad idea to use a different type... it wont complain at compile time..but it'll create edje files that are bad. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
