As the author of illume stuff, this is a hack. I agree. Fix it proper, or don't fix it. As always, patches are welcome...but improper patches do get rejected. Using 'layout' to "Avoid" the problem is no solution.....
dh On 12/06/11 19:00, Carsten Haitzler (The Rasterman) wrote: > On Tue, 06 Dec 2011 14:48:16 +0000 (GMT) PRINCE KUMAR DUBEY > <prince.du...@samsung.com> said: > >> May be I didn't explain the problem properly. >> The issue is: >> focus is not traversing from parent window through conformant to its content >> or vice versa. Since, conformant is an edje object, focus chain breaks here. >> For that, I added elm_layout widget so, in widget hierarchy focus can >> traverse from top(or bottom) to bottom(or top) through conformant. > > yes - and that's a hack. most widgets in elm are/have edje objects and they > handle passing focus to the child via a function. look at > _elm_frame_focus_next_hook() in elm_frame.c - the passing focus to the layout > is a "fallback" for ultra simple widgets that just stuff elm widgets directly > as children. there is an edje object in between here. just add that func into > conformant and register it, don't add a layout in addition to the current edje > obj. > >> Thanks, >> Prince >> ------- Original Message ------- >> Sender : Carsten Haitzler<ras...@rasterman.com> >> Date : Dec 06, 2011 15:10 (GMT+05:30) >> Title : Re: [E-devel] [Patch] elm_conform patch >> >> On Tue, 06 Dec 2011 18:31:48 +0900 ChunEon Park said: >> >> i'd say - don't use anything. elm_conformant should be doing this by itself >> just like layout, box, frame etc. manage it too. >> >>> Then use a box. Box does not need more style and simple to use. >>> Thank you. >>> ------------------------------------ >>> -Regards, Hermet- >>> >>> -----Original Message----- >>> From: "Carsten Haitzler"<ras...@rasterman.com> >>> To: "Enlightenment developer >>> list"<enlightenment-devel@lists.sourceforge.net> Cc: "PRINCE KUMAR >>> DUBEY"<prince.du...@samsung.com> Sent: 11-12-06(?) 18:17:21 >>> Subject: Re: [E-devel] [Patch] elm_conform patch >>> On Fri, 25 Nov 2011 13:06:27 +0000 (GMT) PRINCE KUMAR DUBEY >>> <prince.du...@samsung.com> said: >>>> >>>> Hi, >>>> >>>> Attachment to the mail is elm_conform patch. >>>> Change Log: >>>> 1. Focus chain issue fix by inserting elm_layout in hierarchy . >>> i think this is a bit of a hack... i don't like this. so reject because of >>> this. i think conformant is just not handling focus next/hook stuff right. >>> look at other widgets for example (eg frame). >>>> 2. When no geometry information of indicator/softkey/keyboard, resetting >>>> the geometry. >>> i could accept this bit of the patch if you split it. or re-submit with >>> above stuff fixed/improved :) >>>> Please review it. >>>> I'd appreciate any comments on this. >>>> >>>> Thank you, >>>> Prince >>> -- >>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >>> The Rasterman (Carsten Haitzler) ras...@rasterman.com >>> ------------------------------------------------------------------------------ >>> Cloud Services Checklist: Pricing and Packaging Optimization >>> This white paper is intended to serve as a reference, checklist and point >>> of discussion for anyone considering optimizing the pricing and packaging >>> model of a cloud services business. Read Now! >>> http://www.accelacomm.com/jaw/sfnl/114/51491232/ >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> ------------------------------------------------------------------------------ >>> Cloud Services Checklist: Pricing and Packaging Optimization >>> This white paper is intended to serve as a reference, checklist and point >>> of discussion for anyone considering optimizing the pricing and packaging >>> model of a cloud services business. Read Now! >>> http://www.accelacomm.com/jaw/sfnl/114/51491232/ >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> -- >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> The Rasterman (Carsten Haitzler) ras...@rasterman.com > ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
