Dear MJ, Thanks a lot for the patch, this is a very needed feature, however I have a couple of comments on the implementation.
The reason I was postponing implementing word selection for entry, is that it's not that trivial. There's a complete standard on word boundaries that has to be implemented (http://unicode.org/reports/tr29/#Word_Boundaries) for it to work correctly for all languages. I'm not against implementing an incomplete implementation (i.e one that just filters according to some chars) until we get around to doing the complete implementation, but in that case, edje_object_part_text_word_separators_set must be removed, as it won't be useful in the future. We need to make the incomplete implementation look like a complete implementation and just behave differently in the details. Personally, I prefer having an implementation inside textblock as it has more information, something like: "cursor_to_word_end" and "cursor_to_word_start". Also, I can see you changed the way _curs_back behaves, but judging from the textblock code, your change is not needed as it's already like that there... Also, I don't see how it relates to your change because a paragraph separator is a word separator anyway. The comments above are especially relevant for languages that don't use spaces that often, or that break words without hyphens. I believe that using the line breaking algorithm (that we already have) will give better results than working with delimiters (although it won't be perfect itself). In conclusion, I wouldn't mind applying a patch that just automatically handles this (without exposing any API to the user) as first step towards a complete implementation, but I do believe implementing it inside textblock as described above is a better solution. Therefore, this patch can't be applied in it's current form, but needs to be adjusted as Vincent suggested in his mails, and as I suggested above. Waiting to hear your thoughts on the matter. -- Tom. On 07/12/11 05:52, Myungjae Lee wrote: > Dear, Tom, Raster and EFL people. > > Now I'm trying to reduce the code diffs between EFL svn and my company's > local git repository. > I'm sending you entry-related patches continuously those are specialized in > mobile environment such as selection handlers and magnifier. > > First, I attached edje entry patch for double click word selection. > > It can be applied in all current entry selection modes (default and > explicit mode). > But at this moment default mode has some bugs with scrollers due to > 'EVAS_EVENT_FLAGS_ON_HOLD' event flag, and in the explicit mode canceling > selection is not as familiar as other word processor. Therefore current > word selection is just same with selecting word by clicking select > contextual menu and dragging mouse to the end of the word. > > This can be improved with selection mode later and triple click line > selection also can be added in a similar way. > I added an API (edje_object_part_text_word_separators_set) to control word > separators in an application. > > Please review this patch and apply it if it's acceptable. > Or if you have any opinion for this feel free to give me a feedback. > > Thanks. ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
