On Sat, 24 Dec 2011 12:06:07 +0100 Cedric BAIL <cedric.b...@free.fr> wrote:
> On Sat, Dec 24, 2011 at 8:44 AM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: > > Log: > > maybe prevent a leak but probably not > > > > > > Author: discomfitor > > Date: 2011-12-23 23:44:07 -0800 (Fri, 23 Dec 2011) > > New Revision: 66492 > > Trac: http://trac.enlightenment.org/e/changeset/66492 > > > > Modified: > > trunk/e/src/bin/e_backlight.c > > > > Modified: trunk/e/src/bin/e_backlight.c > > =================================================================== > > --- trunk/e/src/bin/e_backlight.c 2011-12-24 07:29:21 UTC (rev 66491) > > +++ trunk/e/src/bin/e_backlight.c 2011-12-24 07:44:07 UTC (rev 66492) > > @@ -254,7 +254,10 @@ > > if (!devs) return; > > } > > EINA_LIST_FREE(devs, f) > > - bl_sysval = f; > > + { > > + eina_stringshare_replace(&bl_sysval, NULL); > > + bl_sysval = f; > > + } > > This one is very strange. I don't see the rest of the code, but the > normal use would have been eina_stringshare_replace(&bl_sysval, f). > Your use can lead to the premature death of f. > > > } > > > > static void > > > > > > ------------------------------------------------------------------------------ > > Write once. Port to many. > > Get the SDK and tools to simplify cross-platform app development. Create > > new or port existing apps to sell to consumers worldwide. Explore the > > Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join > > http://p.sf.net/sfu/intel-appdev > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > you'll just have to trust me when I say that it's fine ------------------------------------------------------------------------------ Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
