Nooo!
aspect_ratio_retained APIs had to be DEPRECATED not just removed.
Any reason for that?

Daniel Juyung Seo (SeoZ)

On Fri, Jan 6, 2012 at 2:55 PM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
> aspect_ratio_retained -> aspect_fixed
>
>
> Author:       discomfitor
> Date:         2012-01-05 21:55:51 -0800 (Thu, 05 Jan 2012)
> New Revision: 66926
> Trac:         http://trac.enlightenment.org/e/changeset/66926
>
> Modified:
>  trunk/elementary/doc/examples.dox 
> trunk/elementary/src/examples/image_example_01.c 
> trunk/elementary/src/lib/elm_image.c trunk/elementary/src/lib/elm_image.h 
> trunk/elementary/src/lib/elm_photo.c trunk/elementary/src/lib/els_icon.c 
> trunk/elementary/src/lib/els_icon.h
>
> Modified: trunk/elementary/doc/examples.dox
> ===================================================================
> --- trunk/elementary/doc/examples.dox   2012-01-06 05:52:27 UTC (rev 66925)
> +++ trunk/elementary/doc/examples.dox   2012-01-06 05:55:51 UTC (rev 66926)
> @@ -3472,7 +3472,7 @@
>   * elm_image_orient_set() is used to flip the image around the (1, 0) (0, 1)
>   * diagonal.
>   *
> -  * elm_image_aspect_ratio_retained_set() is used to keep the original aspect
> +  * elm_image_aspect_fixed_set() is used to keep the original aspect
>   * ratio of the image, even when the window is resized to another aspect 
> ratio.
>   *
>   * elm_image_fill_outside_set() is used to ensure that the image will fill 
> the
>
> Modified: trunk/elementary/src/examples/image_example_01.c
> ===================================================================
> --- trunk/elementary/src/examples/image_example_01.c    2012-01-06 05:52:27 
> UTC (rev 66925)
> +++ trunk/elementary/src/examples/image_example_01.c    2012-01-06 05:55:51 
> UTC (rev 66926)
> @@ -39,7 +39,7 @@
>    elm_image_scale_set(image, EINA_FALSE, EINA_TRUE);
>    elm_image_smooth_set(image, EINA_FALSE);
>    elm_image_orient_set(image, ELM_IMAGE_FLIP_HORIZONTAL);
> -   elm_image_aspect_ratio_retained_set(image, EINA_TRUE);
> +   elm_image_aspect_fixed_set(image, EINA_TRUE);
>    elm_image_fill_outside_set(image, EINA_TRUE);
>    elm_image_editable_set(image, EINA_TRUE);
>
>
> Modified: trunk/elementary/src/lib/elm_image.c
> ===================================================================
> --- trunk/elementary/src/lib/elm_image.c        2012-01-06 05:52:27 UTC (rev 
> 66925)
> +++ trunk/elementary/src/lib/elm_image.c        2012-01-06 05:55:51 UTC (rev 
> 66926)
> @@ -322,21 +322,21 @@
>  }
>
>  EAPI void
> -elm_image_aspect_ratio_retained_set(Evas_Object *obj, Eina_Bool retained)
> +elm_image_aspect_fixed_set(Evas_Object *obj, Eina_Bool fixed)
>  {
>    ELM_CHECK_WIDTYPE(obj, widtype);
>    Widget_Data *wd = elm_widget_data_get(obj);
>    if (!wd) return;
> -   return _els_smart_icon_aspect_ratio_retained_set(wd->img, retained);
> +   return _els_smart_icon_aspect_fixed_set(wd->img, fixed);
>  }
>
>  EAPI Eina_Bool
> -elm_image_aspect_ratio_retained_get(const Evas_Object *obj)
> +elm_image_aspect_fixed_get(const Evas_Object *obj)
>  {
>    ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
>    Widget_Data *wd = elm_widget_data_get(obj);
>    if (!wd) return EINA_FALSE;
> -   return _els_smart_icon_aspect_ratio_retained_get(wd->img);
> +   return _els_smart_icon_aspect_fixed_get(wd->img);
>  }
>
>  /* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/
>
> Modified: trunk/elementary/src/lib/elm_image.h
> ===================================================================
> --- trunk/elementary/src/lib/elm_image.h        2012-01-06 05:52:27 UTC (rev 
> 66925)
> +++ trunk/elementary/src/lib/elm_image.h        2012-01-06 05:55:51 UTC (rev 
> 66926)
> @@ -218,10 +218,10 @@
>  * and the image will fill the entire object (@p fill_outside is @c 
> EINA_TRUE).
>  *
>  * @note This option will have no effect if
> - * elm_image_aspect_ratio_retained_set() is set to @c EINA_FALSE.
> + * elm_image_aspect_fixed_set() is set to @c EINA_FALSE.
>  *
>  * @see elm_image_fill_outside_get()
> - * @see elm_image_aspect_ratio_retained_set()
> + * @see elm_image_aspect_fixed_set()
>  *
>  * @ingroup Image
>  */
> @@ -351,7 +351,7 @@
>  * Set whether the original aspect ratio of the image should be kept on 
> resize.
>  *
>  * @param obj The image object.
> - * @param retained @c EINA_TRUE if the image should retain the aspect,
> + * @param fixed @c EINA_TRUE if the image should retain the aspect,
>  * @c EINA_FALSE otherwise.
>  *
>  * The original aspect ratio (width / height) of the image is usually
> @@ -359,12 +359,12 @@
>  * this original aspect, and the way that the image is fit into the object's
>  * area depends on the option set by elm_image_fill_outside_set().
>  *
> - * @see elm_image_aspect_ratio_retained_get()
> + * @see elm_image_aspect_fixed_get()
>  * @see elm_image_fill_outside_set()
>  *
>  * @ingroup Image
>  */
> -EAPI void             elm_image_aspect_ratio_retained_set(Evas_Object *obj, 
> Eina_Bool retained);
> +EAPI void             elm_image_aspect_fixed_set(Evas_Object *obj, Eina_Bool 
> fixed);
>
>  /**
>  * Get if the object retains the original aspect ratio.
> @@ -375,7 +375,7 @@
>  *
>  * @ingroup Image
>  */
> -EAPI Eina_Bool        elm_image_aspect_ratio_retained_get(const Evas_Object 
> *obj);
> +EAPI Eina_Bool        elm_image_aspect_fixed_get(const Evas_Object *obj);
>
>  /**
>  * @}
>
> Modified: trunk/elementary/src/lib/elm_photo.c
> ===================================================================
> --- trunk/elementary/src/lib/elm_photo.c        2012-01-06 05:52:27 UTC (rev 
> 66925)
> +++ trunk/elementary/src/lib/elm_photo.c        2012-01-06 05:55:51 UTC (rev 
> 66926)
> @@ -614,7 +614,7 @@
>    ELM_CHECK_WIDTYPE(obj, widtype);
>    Widget_Data *wd = elm_widget_data_get(obj);
>    if (!wd) return;
> -   return _els_smart_icon_aspect_ratio_retained_set(wd->img, fixed);
> +   return _els_smart_icon_aspect_fixed_set(wd->img, fixed);
>  }
>
>  EAPI Eina_Bool
> @@ -623,7 +623,7 @@
>    ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
>    Widget_Data *wd = elm_widget_data_get(obj);
>    if (!wd) return EINA_FALSE;
> -   return _els_smart_icon_aspect_ratio_retained_get(wd->img);
> +   return _els_smart_icon_aspect_fixed_get(wd->img);
>  }
>
>
>
> Modified: trunk/elementary/src/lib/els_icon.c
> ===================================================================
> --- trunk/elementary/src/lib/els_icon.c 2012-01-06 05:52:27 UTC (rev 66925)
> +++ trunk/elementary/src/lib/els_icon.c 2012-01-06 05:55:51 UTC (rev 66926)
> @@ -24,7 +24,7 @@
>    Eina_Bool show : 1;
>    Eina_Bool edit : 1;
>    Eina_Bool edje : 1;
> -   Eina_Bool aspect_ratio_retained: 1;
> +   Eina_Bool aspect_fixed: 1;
>    Elm_Image_Orient orient;
>  };
>
> @@ -489,27 +489,27 @@
>  }
>
>  void
> -_els_smart_icon_aspect_ratio_retained_set(Evas_Object *obj, Eina_Bool 
> retained)
> +_els_smart_icon_aspect_fixed_set(Evas_Object *obj, Eina_Bool fixed)
>  {
>    Smart_Data *sd;
>
>    sd = evas_object_smart_data_get(obj);
>    if (!sd) return;
>
> -   retained = !!retained;
> -   if (sd->aspect_ratio_retained == retained) return;
> -   sd->aspect_ratio_retained = retained;
> +   fixed = !!fixed;
> +   if (sd->aspect_fixed == fixed) return;
> +   sd->aspect_fixed = fixed;
>    _smart_reconfigure(sd);
>  }
>
>  Eina_Bool
> -_els_smart_icon_aspect_ratio_retained_get(const Evas_Object *obj)
> +_els_smart_icon_aspect_fixed_get(const Evas_Object *obj)
>  {
>    Smart_Data *sd;
>
>    sd = evas_object_smart_data_get(obj);
>    if (!sd) return EINA_FALSE;
> -   return sd->aspect_ratio_retained;
> +   return sd->aspect_fixed;
>  }
>
>  /* local subsystem globals */
> @@ -547,7 +547,7 @@
>         if (iw < 1) iw = 1;
>         if (ih < 1) ih = 1;
>
> -        if (sd->aspect_ratio_retained)
> +        if (sd->aspect_fixed)
>           {
>              h = ((double)ih * w) / (double)iw;
>              if (sd->fill_inside)
> @@ -635,7 +635,7 @@
>    sd->fill_inside = EINA_TRUE;
>    sd->scale_up = EINA_TRUE;
>    sd->scale_down = EINA_TRUE;
> -   sd->aspect_ratio_retained = EINA_TRUE;
> +   sd->aspect_fixed = EINA_TRUE;
>    sd->size = 64;
>    sd->scale = 1.0;
>    evas_object_smart_member_add(sd->obj, obj);
>
> Modified: trunk/elementary/src/lib/els_icon.h
> ===================================================================
> --- trunk/elementary/src/lib/els_icon.h 2012-01-06 05:52:27 UTC (rev 66925)
> +++ trunk/elementary/src/lib/els_icon.h 2012-01-06 05:55:51 UTC (rev 66926)
> @@ -22,6 +22,6 @@
>  void             _els_smart_icon_edit_set(Evas_Object *obj, Eina_Bool, 
> Evas_Object *parent);
>  Eina_Bool        _els_smart_icon_edit_get(const Evas_Object *obj);
>  Evas_Object     *_els_smart_icon_edje_get(Evas_Object *obj);
> -void             _els_smart_icon_aspect_ratio_retained_set(Evas_Object *obj, 
> Eina_Bool retained);
> -Eina_Bool        _els_smart_icon_aspect_ratio_retained_get(const Evas_Object 
> *obj);
> +void             _els_smart_icon_aspect_fixed_set(Evas_Object *obj, 
> Eina_Bool fixed);
> +Eina_Bool        _els_smart_icon_aspect_fixed_get(const Evas_Object *obj);
>  void             _els_smart_icon_preload_set(Evas_Object *obj, Eina_Bool 
> disable);
>
>
> ------------------------------------------------------------------------------
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> _______________________________________________
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to