Suppose it could have went either way...If you think it would really be better by moving the MakeCurrent, then I'll do it :)
dh On 01/12/12 06:46, s...@tango.flipp.net wrote: > Why not move eglMakeCurrent? So you keep one if. > > S. > >> Log: >> Evas (gl_x11): We cannot call eglMakeCurrent if we have already called >> eglTerminate prior (eg: eglTerminate was in the wrong place here). >> >> >> >> Author: devilhorns >> Date: 2012-01-11 22:06:07 -0800 (Wed, 11 Jan 2012) >> New Revision: 67119 >> Trac: http://trac.enlightenment.org/e/changeset/67119 >> >> Modified: >> trunk/evas/src/modules/engines/gl_x11/evas_x_main.c >> >> Modified: trunk/evas/src/modules/engines/gl_x11/evas_x_main.c >> =================================================================== >> --- trunk/evas/src/modules/engines/gl_x11/evas_x_main.c 2012-01-12 >> 05:36:47 UTC (rev 67118) >> +++ trunk/evas/src/modules/engines/gl_x11/evas_x_main.c 2012-01-12 >> 06:06:07 UTC (rev 67119) >> @@ -534,10 +534,10 @@ >> if (ref == 0) >> { >> if (context) eglDestroyContext(gw->egl_disp, context); >> - eglTerminate(gw->egl_disp); >> context = EGL_NO_CONTEXT; >> } >> eglMakeCurrent(gw->egl_disp, EGL_NO_SURFACE, EGL_NO_SURFACE, >> EGL_NO_CONTEXT); >> + if (ref == 0) eglTerminate(gw->egl_disp); >> #else >> if (gw->glxwin) glXDestroyWindow(gw->disp, gw->glxwin); >> if (ref == 0) >> >> >> ------------------------------------------------------------------------------ >> RSA(R) Conference 2012 >> Mar 27 - Feb 2 >> Save $400 by Jan. 27 >> Register now! >> http://p.sf.net/sfu/rsa-sfdev2dev2 >> _______________________________________________ >> enlightenment-svn mailing list >> enlightenment-...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> > > > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Mar 27 - Feb 2 > Save $400 by Jan. 27 > Register now! > http://p.sf.net/sfu/rsa-sfdev2dev2 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ RSA(R) Conference 2012 Mar 27 - Feb 2 Save $400 by Jan. 27 Register now! http://p.sf.net/sfu/rsa-sfdev2dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
