Hello.

On Fri, 2012-01-13 at 10:28, Gustavo Sverzut Barbieri wrote:
> On Fri, Jan 13, 2012 at 9:39 AM, Stefan Schmidt
> <ste...@datenfreihafen.org> wrote:
> > With the static attribute set gcc 4.6 complains like this:
> > warning: 'ALPHA_SSE3' is static but used in inline function 
> > 'sub4_alpha_sse3' which is not static
> 
> did not look at the code, but I wonder if there is a way to make the
> function static inline.

Thanks for pointing out my lazyness. :)

It seems possible. Updated patch attached.

regards
Stefan Schmidt
commit ada33925ceb7bbb61d5e7348c441ce9ba1957831
Author: Stefan Schmidt <ste...@datenfreihafen.org>
Date:   Fri Jan 13 11:37:44 2012 +0100

    evas_blend_ops: Fix gcc complains about static used in non static inline functions.
    
    Make the functions static as well to avoid gcc warnings like this:
    warning: 'ALPHA_SSE3' is static but used in inline function 'sub4_alpha_sse3' which is not static
    
    Signed-off-by: Stefan Schmidt <ste...@datenfreihafen.org>

diff --git a/evas/src/lib/include/evas_blend_ops.h b/evas/src/lib/include/evas_blend_ops.h
index 1ada384..6bd1f16 100644
--- a/evas/src/lib/include/evas_blend_ops.h
+++ b/evas/src/lib/include/evas_blend_ops.h
@@ -200,7 +200,7 @@ static __m128i RGB_MASK_SSE3;
 
 static __m128i ALPHA_SSE3;
 
-EFL_ALWAYS_INLINE __m128i
+static EFL_ALWAYS_INLINE __m128i
 mul_256_sse3(__m128i a, __m128i c) {
 
    /* prepare alpha for word multiplication */
@@ -228,7 +228,7 @@ mul_256_sse3(__m128i a, __m128i c) {
    return _mm_add_epi32(c0, c1);
 }
 
-EFL_ALWAYS_INLINE __m128i
+static EFL_ALWAYS_INLINE __m128i
 sub4_alpha_sse3(__m128i c) {
 
    __m128i c0 = c;
@@ -237,7 +237,7 @@ sub4_alpha_sse3(__m128i c) {
    return _mm_sub_epi32(ALPHA_SSE3, c0);
 }
 
-EFL_ALWAYS_INLINE __m128i
+static EFL_ALWAYS_INLINE __m128i
 interp4_256_sse3(__m128i a, __m128i c0, __m128i c1)
 {
    const __m128i zero = _mm_setzero_si128();
@@ -289,7 +289,7 @@ interp4_256_sse3(__m128i a, __m128i c0, __m128i c1)
    return  (__m128i) _mm_shuffle_ps( (__m128)cl_sub, (__m128)ch_sub, 0x44);
 }
 
-EFL_ALWAYS_INLINE __m128i
+static EFL_ALWAYS_INLINE __m128i
 mul_sym_sse3(__m128i a, __m128i c) {
 
       /* Prepare alpha for word mult */
@@ -318,7 +318,7 @@ mul_sym_sse3(__m128i a, __m128i c) {
       return _mm_add_epi32(c0, c1);
 }
 
-EFL_ALWAYS_INLINE __m128i
+static EFL_ALWAYS_INLINE __m128i
 mul4_sym_sse3(__m128i x, __m128i y) {
 
    const __m128i zero = _mm_setzero_si128();
@@ -341,7 +341,7 @@ mul4_sym_sse3(__m128i x, __m128i y) {
    return  _mm_packus_epi16(r_l, r_h);
 }
 
-EFL_ALWAYS_INLINE __m128i
+static EFL_ALWAYS_INLINE __m128i
 mul3_sym_sse3(__m128i x, __m128i y) {
 
    __m128i res = mul4_sym_sse3(x, y);
------------------------------------------------------------------------------
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to