On Fri, 13 Jan 2012 12:39:26 +0100 Stefan Schmidt <ste...@datenfreihafen.org> wrote:
> There are more problems like this in ecore, but many been reported due to not > enabled configure flags on my side. Like cacoa or gestures. Leave them as is > for now. > > Signed-off-by: Stefan Schmidt <ste...@datenfreihafen.org> > --- > ecore/src/lib/ecore_con/ecore_con_info.c | 4 ---- > ecore/src/lib/ecore_x/xlib/ecore_x_randr_11.c | 5 ----- > 2 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/ecore/src/lib/ecore_con/ecore_con_info.c > b/ecore/src/lib/ecore_con/ecore_con_info.c index f451f6a..c98cbab 100644 > --- a/ecore/src/lib/ecore_con/ecore_con_info.c > +++ b/ecore/src/lib/ecore_con/ecore_con_info.c > @@ -244,7 +244,6 @@ ecore_con_info_get(Ecore_Con_Server *svr, > unsigned char *tosend = NULL; > int tosend_len; > int canonname_len = 0; > - int err; > > eina_convert_itoa(svr->ecs ? svr->ecs->port : svr->port, service); > /* CHILD */ > @@ -280,14 +279,11 @@ ecore_con_info_get(Ecore_Con_Server *svr, > memcpy(container->ip, hbuf, sizeof(container->ip)); > memcpy(container->service, sbuf, > sizeof(container->service)); } > - > - err = write(fd[1], tosend, tosend_len); > } > > if (result) > freeaddrinfo(result); > > - err = write(fd[1], "", 1); > close(fd[1]); > #if defined(__USE_ISOC99) && !defined(__UCLIBC__) > _Exit(0); this entire patch looks wrong. I think what you wanted to do was just remove the 'err' variable, but instead you actually removed the entire write operation. in the future: 1) attach patches instead of inlining them 2) separate patch contents by component (eg. the two patches in this mail should have actually been two separate patches since they will require two people to review) ------------------------------------------------------------------------------ RSA(R) Conference 2012 Mar 27 - Feb 2 Save $400 by Jan. 27 Register now! http://p.sf.net/sfu/rsa-sfdev2dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
