On Sat, 18 Feb 2012 01:28:21 +0900 Hyoyoung Chang <hyoyo...@gmail.com> said:
ok in. i added 2 #defines though for the header values so if people want to have const classes in code this makes it easier to define without knowing what the header has. :) > well, that means you have expectations to this feature. > that's very good for me and thanks. > revised version is attached. > > On Fri, Feb 17, 2012 at 8:53 PM, Carsten Haitzler <ras...@rasterman.com> > wrote: > > On Thu, 16 Feb 2012 15:10:16 +0900 Hyoyoung Chang <hyoyo...@gmail.com> said: > > > > can you adjust elc_fileselector.c to use the new creation/free of smart > > classes. also test_store.c as well? :) (i know - the requests keep coming! > > ) :) > > > >> oops i miss that. thanks. > >> attaching improved version > >> > >> On Thu, Feb 16, 2012 at 2:59 PM, Daniel Juyung Seo <seojuyu...@gmail.com> > >> wrote: > >> > Great! > >> > But add NULL check for itc. > >> > Thanks. > >> > > >> > Daniel Juyung Seo (SeoZ) > >> > > >> > On Wed, Feb 15, 2012 at 7:09 PM, Hyoyoung Chang <hyoyo...@gmail.com> > >> > wrote: > >> > > >> >> yeah, it's right. > >> >> added free and ref to examples. > >> >> > >> >> On Tue, Feb 14, 2012 at 2:47 PM, Carsten Haitzler <ras...@rasterman.com> > >> >> wrote: > >> >> > On Mon, 13 Feb 2012 19:07:07 +0900 Hyoyoung Chang <hyoyo...@gmail.com> > >> >> said: > >> >> > > >> >> > ooh something i didn't realize - you should free item class in test > >> >> examples > >> >> > after u are done filling genlist with items - so the example is good. > >> >> > (otherwise they will leak) :) > >> >> > > >> >> >> So it's revised version. > >> >> >> I changed for 1~4. > >> >> >> And one more thing is changed. > >> >> >> ref/unref functions are public. > >> >> >> Because refcount start from 1. > >> >> >> Thank you. > >> >> >> > >> >> >> On Mon, Feb 13, 2012 at 5:11 PM, Carsten Haitzler > >> >> >> <ras...@rasterman.com > >> >> > > >> >> >> wrote: > >> >> >> > On Fri, 10 Feb 2012 18:26:08 +0900 Hyoyoung Chang > >> >> >> > <hyoyo...@gmail.com> > >> >> said: > >> >> >> > > >> >> >> > 1. your patch has your "minw ... wd->w" stuff (bugfix at genlist > >> >> rotation) > >> >> >> > 2. refcount should start at 1 imho. > >> >> >> > 3. delete_me -> use bitfield (delete_me : 1) > >> >> >> > 4. i'd prefer the version field to be at the start, not end of > >> >> >> > class. > >> >> i kn-w > >> >> >> > this breaks abi with current apps, but we have to do this to make > >> >> things > >> >> >> > work into the future. also move refcount and delete_me flag to the > >> >> start > >> >> >> > too. keep func at the end please :) > >> >> >> > > >> >> >> > fix these and then thumbs up :) > >> >> >> > > >> >> >> >> Dear all. > >> >> >> >> > >> >> >> >> I make controversial apis for item class management. > >> >> >> >> As raster and other guys suggest, I simplify APIs and its > >> >> >> >> behaviors. > >> >> >> >> > >> >> >> >> First, Two public apis and two internal apis are introduced > >> >> >> >> > >> >> >> >> +EAPI Elm_Genlist_Item_Class * > >> >> >> >> +elm_genlist_item_class_new(void) > >> >> >> >> > >> >> >> >> +EAPI void > >> >> >> >> +elm_genlist_item_class_free(Elm_Genlist_Item_Class *itc) > >> >> >> >> > >> >> >> >> +void > >> >> >> >> +_elm_genlist_item_class_ref(Elm_Genlist_Item_Class *itc) > >> >> >> >> > >> >> >> >> +void > >> >> >> >> +_elm_genlist_item_class_unref(Elm_Genlist_Item_Class *itc) > >> >> >> >> > >> >> >> >> genlist item class is maintained by genlist in automatic manner. > >> >> >> >> > >> >> >> >> And three fields are introduced in genlist item class. > >> >> >> >> + int version; > >> >> >> >> + unsigned int refcount; > >> >> >> >> + Eina_Bool delete_me; > >> >> >> >> > >> >> >> >> Normally a user add a elm_genlist_item_class by > >> >> elm_genlist_item_class_new > >> >> >> >> (). Then its reference counter is automatic maintained. > >> >> >> >> If the user wanna to remove the elm_genlist_item_class, then call > >> >> >> >> elm_genlist_item_class_free() > >> >> >> >> After refcount reaches to 0, it will be removed. > >> >> >> >> > >> >> >> >> Thank you. > >> >> >> >> > >> >> >> >> PS: I made those apis in genlist. If its accepted i'll make a new > >> >> >> >> patch for gengrid. > >> >> >> > > >> >> >> > > >> >> >> > -- > >> >> >> > ------------- Codito, ergo sum - "I code, therefore I am" > >> >> -------------- > >> >> >> > The Rasterman (Carsten Haitzler) ras...@rasterman.com > >> >> >> > > >> >> > > >> >> > > >> >> > -- > >> >> > ------------- Codito, ergo sum - "I code, therefore I am" > >> >> > -------------- The Rasterman (Carsten Haitzler) > >> >> > ras...@rasterman.com > >> >> > > >> >> > >> >> > >> >> ------------------------------------------------------------------------------ > >> >> Virtualization & Cloud Management Using Capacity Planning > >> >> Cloud computing makes use of virtualization - but cloud computing > >> >> also focuses on allowing computing to be delivered as a service. > >> >> http://www.accelacomm.com/jaw/sfnl/114/51521223/ > >> >> _______________________________________________ > >> >> enlightenment-devel mailing list > >> >> enlightenment-devel@lists.sourceforge.net > >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> > >> >> > >> > ------------------------------------------------------------------------------ > >> > Virtualization & Cloud Management Using Capacity Planning > >> > Cloud computing makes use of virtualization - but cloud computing > >> > also focuses on allowing computing to be delivered as a service. > >> > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > >> > _______________________________________________ > >> > enlightenment-devel mailing list > >> > enlightenment-devel@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
