Dear Daniel, Hello.
I have attached. based on r68179.
Please review this and give any feedbacks.
Thanks always.
Shinwoo Kim.
2012/2/21 Daniel Juyung Seo <seojuyu...@gmail.com>
> I can't apply this patch because raster committed previous patch by
> accident. I give a big SPANK to raster.
> Well.. Shinwoo, can you please make a new patch with latest svn if you're
> ok?
> Or I'll just ignore it.
> Thanks in advance.
>
> Daniel Juyung Seo (SeoZ)
>
> On Mon, Feb 20, 2012 at 2:33 PM, Kim Shinwoo <kimcinoo....@gmail.com>
> wrote:
> > Dear Daniel, Hello~
> >
> > Thanks for your response and sorry for any inconveniences.
> > I have attached revised patch. Please review this and give any feedbacks.
> >
> > Sincerely,
> > Shinwoo Kim.
> >
> > 2012/2/17 Daniel Juyung Seo <seojuyu...@gmail.com>
> >
> >> Dear Kim Shinwoo, thanks for your revised patch.
> >> I also have some comments.
> >>
> >> 1. actionslider
> >> Wrong indentation again. Do not use tab. I fixed it.
> >> Printing enabled position is way too complicated. I simplified it.
> >> This is in SVN! Thanks anyway :)
> >>
> >> 2. box
> >> You didn't remove unnecessary blank line. It's in line 290 in your
> patch.
> >>
> >> Wrong convention. EFL does not use space for casting.
> >> wrong> box = (Evas_Object *) data
> >> right> box = (Evas_Object *)data
> >> wrong> rl = (Eina_List *) evas_ob....
> >> right> rl = (Eina_List *)evas_ob
> >>
> >> Add more (, ) for if conditions.
> >> > (pos == BOX_PACK_POSITION_START || pos == BOX_PACK_POSITION_END)
> >> >> ((pos == BOX_PACK_POSITION_START) || (pos == BOX_PACK_POSITION_END))
> >>
> >> And check other wrong formatting.
> >>
> >> You missed test.c diffs.
> >>
> >> And functions are too much complicated than needed. This can be
> >> enhanced later. So I'll not list up all the things now.
> >>
> >> 3. ecore_evas_x
> >> I think it would be better if you create a separate mail thread for
> this.
> >> This patch covers different boundaries with previous mail.
> >> Anyhow, I have no idea how _ecore_evas_x_title_set works but previous
> >> code was setting icccm_title and netwm_name even parameter 't' was
> >> NULL. Is that ok to skip that setting when 't' is NULL? Actually there
> >> is no NULL check code in ecore_evas_x, I don't know if it's intended
> >> or not. Sometimes it's intended for the lower level code due to the
> >> performance.
> >> I think elm_win_title_set() may filter NULL instead.
> >> Can anybody else review this patch?
> >>
> >> Anyway, thanks for the contribution.
> >>
> >> Daniel Juyung Seo (SeoZ)
> >>
> >> On Thu, Feb 16, 2012 at 3:22 PM, Kim Shinwoo <kimcinoo....@gmail.com>
> >> wrote:
> >> >
> >> > Dear Daniel, Thanks!
> >> >
> >> > I have attached patch based on your comment.
> >> >
> >> > And more..
> >> > elm_win_title_set(win, 0); makes CRASH.
> >> > The last patch is for this. Please review this also and give any
> >> feedbacks.
> >> >
> >> > Sincerely,
> >> > Shinwoo Kim.
> >> >
> >> > 2012/2/16 Daniel Juyung Seo <seojuyu...@gmail.com>
> >> >
> >> > > Thank you very much cnook.
> >> > > I have some brief comments here.
> >> > >
> >> > > 1. actionslider
> >> > > 'switch-case' indentation is wrong. Please check below e-coding
> style
> >> page.
> >> > > http://trac.enlightenment.org/e/wiki/ECoding
> >> > > And for elm_actionslider_enabled_pos_get, how about printing it
> like
> >> > > below?
> >> > > "actionslider enabled pos: left, right"
> >> > >
> >> > > 2. bg
> >> > > Trailing white space in line 14.
> >> > > But this patch looks ok. I removed the trailing white space. In SVN!
> >> > >
> >> > > 3. box
> >> > > Use elm_win_util_standard_add() instead of elm_win_add + elm_bg_add
> for
> >> > > convenience.
> >> > > elm_scroller_bounce_set(sc, 0, 1); -> Use EINA_FALSE, EINA_TRUE for
> >> > > Eina_Bool for consistency.
> >> > > Fix formatting.
> >> > > Remove unnecessary blank line.
> >> > >
> >> > > evas_object_size_hint_min_set(bg, 160, 160);
> >> > > evas_object_size_hint_max_set(bg, 640, 640);
> >> > > -> really needed?
> >> > >
> >> > > Daniel Juyung Seo (SeoZ)
> >> > >
> >> > > On Thu, Feb 16, 2012 at 10:20 AM, cnook <kimci...@gmail.com> wrote:
> >> > >
> >> > > > Dear All, Hello~
> >> > > >
> >> > > > As you guess, the patch is for the elementary_test.
> >> > > > Please review the patch and give any feedbacks.
> >> > > >
> >> > > > The test_actionslider patch is mainly for
> elm_actionslider_xxx_get()
> >> > > APIs.
> >> > > > It would not be a good idea to add test code for such APIs.
> >> > > > So I have planed to add test code except elm_xxx_get() APIs
> >> > > >
> >> > > > Sincerely,
> >> > > > Shinwoo Kim.
> >> > > >
> >> > > >
> >> > > >
> >> > >
> >>
> ------------------------------------------------------------------------------
> >> > > > Virtualization & Cloud Management Using Capacity Planning
> >> > > > Cloud computing makes use of virtualization - but cloud computing
> >> > > > also focuses on allowing computing to be delivered as a service.
> >> > > > http://www.accelacomm.com/jaw/sfnl/114/51521223/
> >> > > > _______________________________________________
> >> > > > enlightenment-devel mailing list
> >> > > > enlightenment-devel@lists.sourceforge.net
> >> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >> > > >
> >> > > >
> >> > >
> >> > >
> >>
> ------------------------------------------------------------------------------
> >> > > Virtualization & Cloud Management Using Capacity Planning
> >> > > Cloud computing makes use of virtualization - but cloud computing
> >> > > also focuses on allowing computing to be delivered as a service.
> >> > > http://www.accelacomm.com/jaw/sfnl/114/51521223/
> >> > > _______________________________________________
> >> > > enlightenment-devel mailing list
> >> > > enlightenment-devel@lists.sourceforge.net
> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >> > >
> >> >
> >> >
> >>
> ------------------------------------------------------------------------------
> >> > Virtualization & Cloud Management Using Capacity Planning
> >> > Cloud computing makes use of virtualization - but cloud computing
> >> > also focuses on allowing computing to be delivered as a service.
> >> > http://www.accelacomm.com/jaw/sfnl/114/51521223/
> >> > _______________________________________________
> >> > enlightenment-devel mailing list
> >> > enlightenment-devel@lists.sourceforge.net
> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >> >
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Virtualization & Cloud Management Using Capacity Planning
> >> Cloud computing makes use of virtualization - but cloud computing
> >> also focuses on allowing computing to be delivered as a service.
> >> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> >> _______________________________________________
> >> enlightenment-devel mailing list
> >> enlightenment-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >>
> >
> >
> ------------------------------------------------------------------------------
> > Try before you buy = See our experts in action!
> > The most comprehensive online learning library for Microsoft developers
> > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> > Metro Style Apps, more. Free future releases when you subscribe now!
> > http://p.sf.net/sfu/learndevnow-dev2
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
Index: src/bin/test_box.c
===================================================================
--- src/bin/test_box.c (revision 68179)
+++ src/bin/test_box.c (working copy)
@@ -186,7 +186,7 @@ _unpack_btn_cb(void *data, Evas_Object *obj __UNUS
Eina_List *rl, *l;
int value, svalue;
- box = (Evas_Object *) data;
+ box = (Evas_Object *)data;
rl = (Eina_List *) evas_object_data_get(box, "radio-list");
EINA_LIST_FOREACH(rl, l, radio)
@@ -210,7 +210,7 @@ _unpack_all_btn_cb(void *data, Evas_Object *obj __
Evas_Object *box, *radio;
Eina_List *rl, *l;
- box = (Evas_Object *) data;
+ box = (Evas_Object *)data;
elm_box_unpack_all(box);
rl = (Eina_List *) evas_object_data_get(box, "radio-list");
@@ -253,7 +253,8 @@ _pack(Evas_Object *box, _Box_Pack_Position pos)
int value, svalue, count;
rl = (Eina_List *) evas_object_data_get(box, "radio-list");
- if (!rl && (pos == BOX_PACK_POSITION_START || pos == BOX_PACK_POSITION_END))
+ if (!rl && ((pos == BOX_PACK_POSITION_START) ||
+ (pos == BOX_PACK_POSITION_END)))
{
rd = _radio_new(box, 0);
if (pos == BOX_PACK_POSITION_START) elm_box_pack_start(box, rd);
@@ -278,20 +279,20 @@ _pack(Evas_Object *box, _Box_Pack_Position pos)
rd = _radio_new(box, count);
- switch(pos)
+ switch (pos)
{
- case BOX_PACK_POSITION_START:
- elm_box_pack_start(box, rd);
- break;
- case BOX_PACK_POSITION_BEFORE:
- elm_box_pack_before(box, rd, radio);
- break;
- case BOX_PACK_POSITION_AFTER:
- elm_box_pack_after(box, rd, radio);
- break;
- case BOX_PACK_POSITION_END:
- elm_box_pack_end(box, rd);
- break;
+ case BOX_PACK_POSITION_START:
+ elm_box_pack_start(box, rd);
+ break;
+ case BOX_PACK_POSITION_BEFORE:
+ elm_box_pack_before(box, rd, radio);
+ break;
+ case BOX_PACK_POSITION_AFTER:
+ elm_box_pack_after(box, rd, radio);
+ break;
+ case BOX_PACK_POSITION_END:
+ elm_box_pack_end(box, rd);
+ break;
}
rdg = evas_object_data_get(box, "radio-group");
@@ -308,7 +309,7 @@ _pack_start_btn_cb(void *data, Evas_Object *obj __
Evas_Object *box;
if (!data) return;
- box = (Evas_Object *) data;
+ box = (Evas_Object *)data;
_pack(box, BOX_PACK_POSITION_START);
}
@@ -318,7 +319,7 @@ _pack_before_btn_cb(void *data, Evas_Object *obj _
Evas_Object *box;
if (!data) return;
- box = (Evas_Object *) data;
+ box = (Evas_Object *)data;
_pack(box, BOX_PACK_POSITION_BEFORE);
}
@@ -328,7 +329,7 @@ _pack_after_btn_cb(void *data, Evas_Object *obj __
Evas_Object *box;
if (!data) return;
- box = (Evas_Object *) data;
+ box = (Evas_Object *)data;
_pack(box, BOX_PACK_POSITION_AFTER);
}
@@ -338,14 +339,14 @@ _pack_end_btn_cb(void *data, Evas_Object *obj __UN
Evas_Object *box;
if (!data) return;
- box = (Evas_Object *) data;
+ box = (Evas_Object *)data;
_pack(box, BOX_PACK_POSITION_END);
}
void
test_box_pack(void *data __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
{
- Evas_Object *win, *bg;
+ Evas_Object *win;
Evas_Object *box, *lbox, *rbox;
Evas_Object *sc;
Evas_Object *bt;
@@ -357,11 +358,6 @@ test_box_pack(void *data __UNUSED__, Evas_Object *
elm_win_title_set(win, "Box Pack");
elm_win_autodel_set(win, EINA_TRUE);
- bg = elm_bg_add(win);
- evas_object_size_hint_weight_set(bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
- elm_win_resize_object_add(win, bg);
- evas_object_show(bg);
-
box = elm_box_add(win);
elm_box_horizontal_set(box, EINA_TRUE);
evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
@@ -375,7 +371,7 @@ test_box_pack(void *data __UNUSED__, Evas_Object *
evas_object_size_hint_align_set(lbox, EVAS_HINT_FILL, EVAS_HINT_FILL);
sc = elm_scroller_add(win);
- elm_scroller_bounce_set(sc, 0, 1);
+ elm_scroller_bounce_set(sc, EINA_FALSE, EINA_TRUE);
evas_object_size_hint_weight_set(sc, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(sc, EVAS_HINT_FILL, EVAS_HINT_FILL);
@@ -450,13 +446,12 @@ _cb_check_changed(void *data, Evas_Object *obj, vo
homo = elm_check_state_get(obj);
elm_box_homogeneous_set(box, homo);
-
}
void
test_box_homo(void *data __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
{
- Evas_Object *win, *bg;
+ Evas_Object *win;
Evas_Object *box, *o_bg;
Evas_Object *rd;
char buf[PATH_MAX];
@@ -465,11 +460,6 @@ test_box_homo(void *data __UNUSED__, Evas_Object *
elm_win_title_set(win, "Box Homogeneous");
elm_win_autodel_set(win, EINA_TRUE);
- bg = elm_bg_add(win);
- evas_object_size_hint_weight_set(bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
- elm_win_resize_object_add(win, bg);
- evas_object_show(bg);
-
box = elm_box_add(win);
evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_win_resize_object_add(win, box);
@@ -488,10 +478,8 @@ test_box_homo(void *data __UNUSED__, Evas_Object *
evas_object_smart_callback_add(rd, "changed", _cb_check_changed, box);
elm_box_pack_end(box, rd);
evas_object_show(rd);
-
evas_object_show(o_bg);
- evas_object_size_hint_min_set(bg, 160, 160);
- evas_object_size_hint_max_set(bg, 640, 640);
+
evas_object_resize(win, 320, 320);
evas_object_show(win);
}
@@ -547,7 +535,6 @@ test_box_transition(void *data __UNUSED__, Evas_Ob
bx = elm_box_add(win);
elm_win_resize_object_add(win, bx);
evas_object_size_hint_weight_set(bx, 1.0, 1.0);
-
evas_object_show(bx);
bt = elm_button_add(win);
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
