On 02/29/2012 02:02 AM, Carsten Haitzler (The Rasterman) wrote:
> On Wed, 29 Feb 2012 15:52:07 +0900 Daniel Juyung Seo<seojuyu...@gmail.com>
> said:
>
>> On Wed, Feb 29, 2012 at 2:59 PM, Christopher Michael<cpmicha...@comcast.net
>>> wrote:
>>
>>> On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
>>>> Log:
>>>> elm win: Commented unused function.
>>>>
>>>>     Signed-off-by: Daniel Juyung Seo<juyung....@samsung.com>
>>>>
>>>> Author:       seoz
>>>> Date:         2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
>>>> New Revision: 68533
>>>> Trac:         http://trac.enlightenment.org/e/changeset/68533
>>>>
>>>> Modified:
>>>>     trunk/elementary/src/lib/elm_win.c
>>>>
>>>
>>
>> Hello
>>
>>>
>>> These are going to be employed in code very soon...don't get unused
>>> happy yet.
>>>
>>
>> I knew it would be a temporary fix and I already read your commit.
>> It was for shutting up warning message while building.
>> So don't care :)
>> Thanks.
>
> i kind of agree - at this stage we are tryng to nix all warnings so we can
> focus on the real warnings/problems that turn up. :) if there has to be tmp
> code.. making it not add warns is good.
>
> i highly suggest people use -W -Wall -Wextra :)
>
Already do. But if you are not using m4 silent, then the warnings get 
mixed with the build output, and people don't see them. Seriously, 
enable m4 silent, record the build, grep warning and you'll see the 
larger messes.

dh

>> Daniel Juyung Seo (SeoZ)
>>
>>
>>>
>>> They are just a basis. i'll clean it up. who else takes care of the
>>> unused vars ;) These are going to be used to allow elm to pass a buffer
>>> of the mouse cursor (pixels) to wayland and allow the protocol there to
>>> attach those pixels to the surface of the cursor. if that cursor is
>>> rendered in shm or egl, who cares ;)
>>>
>>> dh
>>>
>>>
>>>> Modified: trunk/elementary/src/lib/elm_win.c
>>>> ===================================================================
>>>> --- trunk/elementary/src/lib/elm_win.c        2012-02-29 04:50:20 UTC
>>> (rev 68532)
>>>> +++ trunk/elementary/src/lib/elm_win.c        2012-02-29 05:05:50 UTC
>>> (rev 68533)
>>>> @@ -102,7 +102,7 @@
>>>>    static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj
>>> __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
>>>>    static void _elm_win_frame_cb_close(void *data, Evas_Object *obj
>>> __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
>>>>
>>>> -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
>>>> +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);
>>>>
>>>>    static const char SIG_DELETE_REQUEST[] = "delete,request";
>>>>    static const char SIG_FOCUS_OUT[] = "focus,out";
>>>> @@ -1547,6 +1547,7 @@
>>>>       evas_object_del(win->win_obj);
>>>>    }
>>>>
>>>> +/*
>>>>    static void
>>>>    _elm_win_pointer_add(Elm_Win *win, const char *style)
>>>>    {
>>>> @@ -1566,6 +1567,7 @@
>>>>       evas_object_resize(win->pointer.obj, 32, 32);
>>>>       evas_object_show(win->pointer.obj);
>>>>    }
>>>> +*/
>>>>
>>>>    #ifdef ELM_DEBUG
>>>>    static void


------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to