What is your take on my initial review? Merging this with color selector
and automatically change between modes, with an option to fix a mode.
This would provide us with more flexibility. For instance most of palette
users (apps) will need to handle color selection. Then there is code to
write to toggle between them and exchange values.
Also, this more I suggest could take different compile or runtime option to
be smart and present both at the same time if screen size allows (desktop
or tablet). Or do a transition and layout more familiar to the platform,
providing greater consistency.
Alternatively we could have these 2 in separate and then a 3 one elc to
combine them, but we did this for others and now we all suffer the pain :-/
On Friday, March 2, 2012, Carsten Haitzler <ras...@rasterman.com> wrote:
> On Tue, 28 Feb 2012 13:05:33 +0900 ChunEon Park<her...@naver.com> said:
>
> well my comment still stands - without being able to load a named
palettes,
> save it. you didnt address # 6 - where u get an object item returned then
u use
> color number (index) to address it. thats a bit inconsistent.
>
>>
>> Here is a Shilpa’s mail forwarded(shilpa.si...@samsung.com)
>>
>> Hi,
>>
>> Please find attached updated patch of new widget
>> colorpalette with review comment
>> fixes.
>> Change Description:
>> New widget elm_colorpalette is added.
>> ColorPalette is a color selection widget.
>> It allows the user to set a series of colors. The
>> colors can be picked by user from the
>> color set by clicking on individual color
>> item.
>>
>> All the review comments given below from 1-7 have been
>> fixed.
>>
>> >>3. support totally custom colorset
>> (clear+add/change your colors)
>> Fixed.[ elm_colorpalette_color_add,
>> elm_colorpalette_clear APIs are supported ]
>> >>4. use a better layout (flow/wrap - yes, i
>> know.. there is a bug there that elm
>> test brings out - u can expand, but not contract
>> horizontally)
>> Fixed.
>> >>5. imho most likely needs the idea of a
>> selected color - so when u click/select
>> that color becomes the current selected color - much
>> like a list has a selected
>> item... this nicely allows for keyboard control too
>> :)
>> Fixed.
>>
>> >>1. have a default color set in USER config
>> (_elm_config or somewhere else maybe)
>> loaded from user config files etc. and saved back to
>> them on editing.
>> >>2. it'd have to also support custom palettes -
>> but handle the saving/loading
>> for you - eg just give palette a name ("default" by
>> default, or "photos" or
>> "painting" etc..) or a full path to save it
>> in.
>>
>> Currently reading colors from config and writing back
>> to it has not been
>> supported, this needs some more analysis, this
>> enhancement will be supported in next patch.
>>
>> Thanks & Regards
>> Shilpa Singh
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler) ras...@rasterman.com
>
>
>
------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
