On Wed, 28 Mar 2012 21:56:23 +0900 Carsten Haitzler (The Rasterman) <ras...@rasterman.com> wrote:
> On Wed, 28 Mar 2012 21:40:37 +1000 David Seikel <onef...@gmail.com> > said: > > > On Wed, 28 Mar 2012 13:29:40 +0200 Leif Middelschulte > > <leif.middelschu...@gmail.com> wrote: > > > > > 2012/3/28 Enlightenment SVN <no-re...@enlightenment.org>: > > > > Log: > > > > put env bug so waiting to happen - env vars wont be set. no > > > > crash though. > > > > > > > > > > > > > > > > Author: raster > > > > Date: 2012-03-28 00:26:22 -0700 (Wed, 28 Mar 2012) > > > > New Revision: 69696 > > > > Trac: http://trac.enlightenment.org/e/changeset/69696 > > > > > > > > Modified: > > > > trunk/e/src/bin/e_start_main.c > > > > > > > > Modified: trunk/e/src/bin/e_start_main.c > > > > =================================================================== > > > > --- trunk/e/src/bin/e_start_main.c 2012-03-28 07:17:46 UTC > > > > (rev 69695) +++ trunk/e/src/bin/e_start_main.c 2012-03-28 > > > > 07:26:22 UTC (rev 69696) @@ -27,9 +27,10 @@ > > > > setenv(var, val, 1); > > > > #else > > > > char *buf; > > > > + size_t size = strlen(var) + 1 + strlen(val) + 1; > > > > > > > > - buf = alloca(strlen(var) + 1 + strlen(val) + 1); > > > > - snprintf(buf, sizeof(buf), "%s=%s", var, val); > > > > + buf = alloca(size; > > > missing right paranthesis here? > > > > How did that even compile? > > the whole section is ifdefed out - i think for bsd or something > obscure that doesnt have setenv(). the code was already broken - it > would have totally failed to set any env var at all, so it improved. > at least you'd know its broken at compile time. Ah, the top of the #if was not in that diff, so could not see straight away under what conditions it tried to compile that bit. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
