Hello. > From: ChunEon Park [mailto:her...@naver.com] > > Hi stefan, this is Hermet :)
Hi hermet :) > I reviewed your patch but just submitted 2 patches, 0002, 0004 Thanks for this! > I didn't understand why is 0001_patch needed. could you explain to me? It shadows another variable name ecore/src/modules/immodules/xim/ecore_imf_xim.c:116: warning: declaration of 'index' shadows a global declaration /usr/include/string.h:487: warning: shadowed declaration is here Not a big deal as we should still handle it correctly but to avoid the warning I just renamed the variable. > and 0003 looks it has incorrect indentations. You might know about that. Thanks for letting me know. Need to fix this and resubmit later today or at the weekend. Regards Stefan Schmidt ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
