Hello. On 05/17/2012 08:05 AM, Tom Hacohen wrote: > On 17/05/12 02:15, Carsten Haitzler (The Rasterman) wrote: > > I know what a changelog is for, but you have to put a line somewhere. > I'm certain you'll agree that "Fixed elm_object_text_set to work when > inserting the text 'aouaA<HA<*(KAo34'." hardly deserves a changelog > entry, as no one complained about it. I'd argue that only major bugs or > bug that were reported deserve changelog entries, but as I said, it's > not really defined ATM.
Well, if you don't have a special case for 'aouaA<HA<*(KAo34' this bug would also affect other text entries. Rare sure, but not as rare as you might think. Adding a changelog with the fixed _root cause_ would still make sense. About the only-a-bug-when-reported I can just say this will not work. I agree that reported bugs have higher priority and should get an entry, but just because it was not reported does not mean it nobody was affected by it. Users are as lazy as developers in this regard. :) >>> As for the backport. It's annoying to do with svn (and our directory >>> structure), very annoying, also, it's driving me nuts. Again, comparing >>> to other projects: that's why there are "version maintainers", just for >>> backporting. When it comes to scratching my own itches: I couldn't care >>> less about backports, I usually do it, but it's really just too annoying. >> >> <just before u svn commit the change> >> svn diff | (cd ~/dev/svn/e/branches/elementary-1.0; patch -p0) >> >> that's annoying? you could script it trivially: >> >> cat backport.sh >> #!/bin/sh >> svn diff | (cd ~/dev/svn/e/branches/$1; patch -p0) >> >> so now it's a simple: >> >> backport.sh elementary-1.0 > > > 1. Yes, it's terribly annoying, and you have to maintain checkouts of > all the branches. I actually would expect this from developers. > 2. It's not as simple as you'll may have conflicts. Sure. And form time to time its even not sensible to do so because too much internals changed. Naturally backports will slow down to the most important ones while code in the dev branch moves on. More likely to happen with elementary right now then say for embryo. > 3. It's not as easy when you work with git-svn and have multiple commits > in your queue (can be done, just not as trivial). I'm sorry, but that really reads like an excuse because do don't want to use your tools in a better way. Making a new branch and bringing over the commits you want to commit and then backport is not that hard with git. You can then rebase, or merge. Local changes come with a cost. > As I said, I know it's important, I'm just saying my "direct" motivation > is to improve the EFL and not to support users. I do support users, I > help on the ML/IRC and generally available. I care about EFL flourishing > and that's why I even bother about arguing. I'm just saying it's getting > a bit annoying. > Heck, I've been bugging everyone for years to write proper commit logs, > doc the code and write unit tests, which achieves stability and more. We all pester for efl and e17 releases for years and now that we have some we need to take care about doing some maintenance as well. Price to pay. > We need to "optimise" the way we work, not only the code we write, and > at the moment, we are very far from ideal in that field. I heartfully agree with you on this. Still just ripping out parts of the workflow that are useful for others is no optimisation but a simple feature removal to save time. :) > Just think about the time wasted, people annoyed by it (me for one) and > compare it to the outcome and the benefits we get from it and let us > know if you still think we should go on the way we do. Interestingly it seems to be easy enough to do backports for raster and cedric. For me it looks like your own setup makes it harder then needed. (No complete checkout, local commits). There is nothing in git and git-svn that would block you from having a good setup for this. regards Stefan Schmidt ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
