I agree with your opinion. I reverted it. The "correctness" should be discussed at elm 2.0. Thanks. -- Jaehwan Kim.
2012년 5월 18일 금요일에 Michael Blumenkrantz님이 작성: > On Wed, 16 May 2012 18:37:51 -0700 > "Enlightenment SVN" <[email protected] <javascript:;>> wrote: > > > Log: > > The separator is not a real item. So it shouldn't be counted. > > > > > > Author: jaehwan > > Date: 2012-05-16 18:37:50 -0700 (Wed, 16 May 2012) > > New Revision: 71185 > > Trac: http://trac.enlightenment.org/e/changeset/71185 > > > > Modified: > > trunk/elementary/src/lib/elm_toolbar.c > > > > Modified: trunk/elementary/src/lib/elm_toolbar.c > > =================================================================== > > --- trunk/elementary/src/lib/elm_toolbar.c 2012-05-16 23:44:46 UTC > > (rev 71184) +++ trunk/elementary/src/lib/elm_toolbar.c 2012-05-17 > > 01:37:50 UTC (rev 71185) @@ -1627,6 +1627,7 @@ > > item->separator = separator; > > scale = (elm_widget_scale_get(obj) * _elm_config->scale); > > _theme_hook_item(obj, item, scale, wd->icon_size); > > + wd->item_count--; > > } > > > > EAPI Eina_Bool > > > > I don't agree with this commit; regardless of "correctness", it breaks > behavior > which is expected from elm 1.0, and anyone counting items will suddenly > receive > a different number than expected if separators are present. > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
