Hello, Some efreet APIs do not check input parameters. So I add checking by using EINA_SAFETY_ON_XXX(). ISO/IEC statndards says that "If an argument to a function has an invalid value, behavior is undefined" . But this is just for the primitive functions such as libc. I think that parameter checking is needed in at least EFL exported APIs to prevent run-time abnormal behavior. EINA_SAFTETY_ON_XXX are better than "if (xxx) return" because it gives error message and can be maintainable. Actually these may be needed for some static internal functions. But I did not add.
If this patches would be acceptable, I will add these checking into other efreet files (efreet_menu, efreet_base, etc.) -- BRs, Kim.
efreet@add_param_check.diff
Description: Binary data
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
