On Mon, 21 May 2012 14:36:17 +0200 Vincent Torri <vincent.to...@gmail.com> said:
> On Mon, May 21, 2012 at 1:51 PM, Carsten Haitzler <ras...@rasterman.com> > wrote: > > On Mon, 21 May 2012 10:04:06 +0200 Vincent Torri <vincent.to...@gmail.com> > > said: > > > > this code is actually right. > > i didn't say that it was wrong. I just said that i don't like that > kind of stuff. but in this situation its kind of a necessity to avoid "bizarre compile issues". > > evas_gl.h conflicts with gl headers - they are > > mutually exclusive since evas_gl is a one-stop shop for gl stuff when using > > it with evas1 - that includes all gl defines and so on. > > > >> i don't like that kind of stuff at all (not only your commit, but the > >> inclusion of specific gl headers). > >> > >> Vincent > >> > >> On Mon, May 21, 2012 at 10:01 AM, Enlightenment SVN > >> <no-re...@enlightenment.org> wrote: > >> > Log: > >> > Separated checks for gl2.h defines and gl2ext.h defines in Evas_GL.h. > >> > > >> > > >> > Author: sung > >> > Date: 2012-05-21 01:01:28 -0700 (Mon, 21 May 2012) > >> > New Revision: 71270 > >> > Trac: http://trac.enlightenment.org/e/changeset/71270 > >> > > >> > Modified: > >> > trunk/evas/src/lib/Evas_GL.h > >> > > >> > Modified: trunk/evas/src/lib/Evas_GL.h > >> > =================================================================== > >> > --- trunk/evas/src/lib/Evas_GL.h 2012-05-21 07:51:41 UTC (rev > >> > 71269) +++ trunk/evas/src/lib/Evas_GL.h 2012-05-21 08:01:28 UTC > >> > (rev 71270) @@ -1038,6 +1038,17 @@ > >> > > >> > #define GL_INVALID_FRAMEBUFFER_OPERATION 0x0506 > >> > > >> > +#else > >> > +# ifndef EVAS_GL_NO_GL_H_CHECK > >> > +# error "You may only include either Evas_GL.h OR use your native > >> > OpenGL's headers. If you use Evas to do GL, then you cannot use the > >> > native gl headers." +# endif +#endif > >> > + > >> > + > >> > +#if !defined(__glext_h_) && !defined(__gl2ext_h_) > >> > +# define __glext_h_ > >> > +# define __gl2ext_h_ > >> > + > >> > //---------------------------// > >> > // GLES extension defines > >> > > >> > > >> > > >> > ------------------------------------------------------------------------------ > >> > Live Security Virtual Conference > >> > Exclusive live event will cover all the ways today's security and > >> > threat landscape has changed and how IT managers can respond. Discussions > >> > will include endpoint security, mobile security and the latest in malware > >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> > _______________________________________________ > >> > enlightenment-svn mailing list > >> > enlightenment-...@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > >> > >> ------------------------------------------------------------------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's security and > >> threat landscape has changed and how IT managers can respond. Discussions > >> will include endpoint security, mobile security and the latest in malware > >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
