Nope. When you call elm_ctxpopup_add() it calls elm_ctxpopup_hover_parent_set(). In elm_ctxpopup_hover_parent_set() calls _parent_cut_off(). At this moment there is no parent yet. So there is a possibility that parent is NULL when _parent_cut_off() is called. Of course we can check parent and do not call _parent_cut_off() in elm_ctxpopup_hover_parent_set(), but this is a matter of choice. I just chose to fix _parent_cut_off(). Thanks.
Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 5:18 PM, ChunEon Park <her...@naver.com> wrote: > I don't understand how ctxpopup is added without parent. > > > > If It is so you should fix that point first. > > > > > ------------------------------------ > > -Regards, Hermet-You should fix that point first. > > > > -----Original Message----- > From: "Daniel Juyung Seo"<seojuyu...@gmail.com> > To: <enlightenment-devel@lists.sourceforge.net>; > Cc: <enlightenment-...@lists.sourceforge.net>; > Sent: 2012-05-22 (화) 17:11:01 > Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib > > Nope. > When you call elm_ctxpopup_add(), wd->parent is NULL. > It doesn't print out warnings even wd->parent is NULL but it is better > to avoid doing a series of unnecessary calls. > So I reverted your commit. > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Tue, May 22, 2012 at 4:09 PM, Enlightenment SVN > <no-reply>@enlightenment.org> wrote: > > Log: > > elementary/ctxpopup - but there would be no parent NULL case. > > > > > > > > Author: hermet > > Date: 2012-05-22 00:09:13 -0700 (Tue, 22 May 2012) > > New Revision: 71303 > > Trac: http://trac.enlightenment.org/e/changeset/71303 > > > > Modified: > > trunk/elementary/src/lib/elc_ctxpopup.c > > > > Modified: trunk/elementary/src/lib/elc_ctxpopup.c > > =================================================================== > > --- trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:05:07 UTC > (rev 71302) > > +++ trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:09:13 UTC > (rev 71303) > > @@ -215,7 +215,7 @@ > > _parent_cut_off(Evas_Object *obj) > > { > > Widget_Data *wd = elm_widget_data_get(obj); > > - if (!wd || !wd->parent) return; > > + if (!wd) return; > > > > evas_object_event_callback_del_full(wd->parent, > > EVAS_CALLBACK_DEL, > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
