great as your first patch! and code looks good to me too. but i have two comments. 1. add const to the parameter of elm_entry_text_style_user_peek. 2. add example for pop and keep to test_entry_style_user.
and here is a tip for thiep. http://trac.enlightenment.org/e/wiki/PatchReview thanks. On May 25, 2012 7:55 PM, "Carsten Haitzler" <ras...@rasterman.com> wrote: > On Thu, 24 May 2012 09:12:45 +0000 (GMT) thiep ha <thiep...@samsung.com> > said: > > looks good with 1 exception. missing as part of the patch a patch to the > Changelog file and adding yourself to AUTHORS. can you add those into your > patch and re-send? > > > Hello, > > > > As we known that, the user style is a convenience way which helps users > to > > work with style without the need of new edc file. It means that users > can set > > their own style (e.g. font, font_size, color) without making new edc > file. > > Currently, in Elementary Entry, there is no APIs supporting users to deal > > with user style stack (e.g. adding, removing). I added three APIs to > Entry > > which are: > > + elm_entry_text_style_user_push: push an style to user style stack. > > + elm_entry_text_style_user_pop: remove the top style from user style > stack. > > + elm_entry_text_style_user_peek: peek the top style from user style > stack. > > With this modification, users only need to call the new api as below to > apply > > desired style: elm_entry_text_style_user_push(en, "DEFAULT='font_size=40 > > color=#FF0000'"); > > > > Please review this patch. > > Thanks. > > > > Best Regards, > > Thiep Ha > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
