On 19/06/2012, at 23:21, Jihoon Kim <imfin...@gmail.com> wrote:

> Thanks for your comment.
> I've fixed and committed according to your comment.

I saw, thanks!



> 
> On Wednesday, June 20, 2012, Gustavo Sverzut Barbieri wrote:
> 
>> On Tue, Jun 19, 2012 at 12:18 PM, Enlightenment SVN
>> <no-re...@enlightenment.org <javascript:;>> wrote:
>>> Log:
>>> xim: add NULL checker
>> 
>> 
>>> +   if (!imf_context_data) return;
>> 
>> As this is an error use EINA_SAFETY_ON_NULL_RETURN() and
>> EINA_SAFETY_ON_NULL_RETURN_VAL() so people can know when it
>> unexpectedly failed.
>> 
>> It would be nice to convert other existing checks to this.
>> 
>> --
>> Gustavo Sverzut Barbieri
>> http://profusion.mobi embedded systems
>> --------------------------------------
>> MSN: barbi...@gmail.com <javascript:;>
>> Skype: gsbarbieri
>> Mobile: +55 (19) 9225-2202
>> 
>> 
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net <javascript:;>
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to