Hi
I took a look at src/lib/elm_flipselector.c and found an erronous
'if( sd->evaling )' that prevented the sizing logic to function correctly.
Changed it to 'if(!sd->evaling)', and even added an explicit
initializa of it's value to EINA_FALSE. See enclosed patch for details.
Please ignore my previous patches, they didn't really address the
cause of the bug.
Regards
- Ingvaldur
On 06/26/2012 05:52 AM, woohyun wrote:
I think this is the problem of elm_flipselector.
It should calculate its min size when there is a change in the length of label.
I'll check it soon :)
-----Original Message-----
From: "Ingvaldur Sigurjonsson"<[email protected]>
To: <[email protected]>;
Cc:
Sent: 2012-06-25 (월) 21:49:06
Subject: [E-devel] [Patch] Elementary : Flip selector test and example patches
Hi
Enclosed you find small patches for Elementary's "Flip selector" test
and example.
Without the patch, the value the flip selector is supposed to show is
way too narrow, so narrow that you only see two characters of it's
value. The patches simply add a 'evas_object_size_hint_align_set(fp,
EVAS_HINT_FILL, EVAS_HINT_FILL);' so the flip-selector widget is resized
when it's container is resized (box,...).
I assume the flip-selector widget width is supposed to be controlled
by the longest length (up to some maximum) of one of it's values but I
dont know how to fix that. Atleast you can see the values with the
enclosed patches.
Files affected by the patch are:
- src/bin/test_flipselector.c
- src/examples/flipselector_example.c
Regards
- Ingvaldur
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats.
http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Index: src/lib/elm_flipselector.c
===================================================================
--- src/lib/elm_flipselector.c (revision 72870)
+++ src/lib/elm_flipselector.c (working copy)
@@ -116,7 +116,7 @@
elm_coords_finger_size_adjust(1, &minw, 2, &minh);
- if (sd->evaling)
+ if (!sd->evaling)
{
sd->evaling = EINA_TRUE;
@@ -621,6 +621,7 @@
(obj, "elm,action,down,stop", "", _signal_val_change_stop, obj);
priv->first_interval = FLIP_FIRST_INTERVAL;
+ priv->evaling = EINA_FALSE;
elm_widget_can_focus_set(obj, EINA_TRUE);
@@ -735,7 +736,7 @@
elm_layout_sizing_eval(obj);
}
- if (eina_list_count(sd->items) >= 2)
+ if (eina_list_count(sd->items) > 1)
elm_layout_signal_emit(obj, "elm,state,button,visible", "elm");
return (Elm_Object_Item *)item;
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
