On Thursday, June 28, 2012, Michael Blumenkrantz wrote: > On Wed, 27 Jun 2012 23:43:23 -0300 > Raphael Kubo da Costa <[email protected]> wrote: > > > Cedric BAIL <[email protected] <javascript:;>> writes: > > > > > I personally think that eina_iterator_free like any free function > > > should just work fine with NULL. I was against at that time, but > > > others won. So we do have this incoherency where some of our free > > > function work with NULL and some don't. > > > > So what can we do to improve the situation here (if it does need to be > > improved)? Speaking more generically, what criteria are used to decide > > that a function should be decorated with EINA_ARG_NONNULL and/or have > > magic checks performed? > > > > I am hugely in favor of having all _free() and _del() functions take NULL > arguments without erroring.
I disagree, in regular situation it should never return a NULL handle, so you should never have a NULL handle to free. If that happened you did some mistake in the code and it's easier to spot and fix. Compatibility with libc is moot: should we also crash on other functions as well?! :-) > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
