On Mon, 09 Jul 2012 07:30:52 +0000 (GMT) Myung-Jae Lee <[email protected]> said:
comments here: 1. magnifier_show/hide - it'd be nice to emit signals to mgf_bg on show and on hide. on hide don't hide the object - emit a signal to hide and then wait for a signal coming back as a reply saying "hide done". see what i did to elm slider with the popup. then hide there when you get the signal saying hide is done. delay hiding of clip until then too. this allows the theme to do things like fade out or zoom out/in on hide and have some effects. :) 2. i'm wondering if scale should be declared in the theme? should it be? i am not totally sure. i suspect maybe you can BUT it should be able to be overridden by elm config values. (in _magnifer_create()). 3. mgf_proxy probably should be swallowed into the mgf_bg, not the clip. in fact the bg should be doing the clipping as it sees fit. you should be adjusting fill x, y, w, h to make the content scroll about as the proxy moves around the screen (and you should track the move and resize objects of the proxy object and modify fill accordingly as it modes/resizes). so you actually can kill the clip object and do it this way. this is more flexible and allows for the edj object to control stacking, layering and other things about the proxy zoom thing. :) 4. i the image u have and edje design should probably split the frame border and the solid bg into 2 objects (layers) so frame is overlayed on top of the swallow that holds the proxy and background solid obj is below that filling in the background. :) that's it, though these are some core structural changes... so that should keep you busy. :) > Cedric, Gustavo and Vincent, thank you for your comments. > > I updated the patch according to your opinions (removed entry APIs and added > 1 elm_config variable to enable or disable magnifier) I know we are in a > feature freeze now but I'd like to make this entry patch be acceptable in svn > when it's possible. So please review this patch when you're available and > give me a feedback if there's something to be fixed. > > Regards, > -------------- > Myungjae Lee. > > > ------- Original Message ------- > Sender : Gustavo Sverzut Barbieri<[email protected]> > Date : 2012-07-06 20:07 (GMT+09:00) > Title : Re: [E-devel] [Patch] [Elementary] added magnifier feature to > elm_entry > > On Friday, July 6, 2012, Cedric BAIL wrote: > > > Hello, > > > > On Fri, Jul 6, 2012 at 7:37 PM, Myung-Jae Lee > > > wrote: > > > I'm trying to add entry features those are useful in the mobile > > envieronment such as magnifier and selection block handlers. > > > Some of these might be conflicted with desktop entries' functionalities > > or meaningless in the desktop entries. > > > Therefore I've splitted the patches according to the functionality and > > I'm sending them one after another. > > > > I do disagree with you. I think this kind of feature could be useful > > for people with limited sightedness on desktop to. > > > > > The attached patch is related to the entry magnifier feature that helps > > user move cursor easily in a mobile entry. > > > This can be more useful with another selection mode in a edje_entry that > > supports moving cursor in mouse_move. > > > However as I described above, I'll send the edje_entry selection patch > > (that will also include one more change in long press detection in an > > elm_entry) right after this magnifier patch is accepted. > > > So, please review this patch just focused on magnifier feature itself. > > > > > > I added next 2 APIs to enable or disable magnifier feature in an entry. > > > - EAPI void elm_entry_magnifier_disabled_set(Evas_Object *obj, Eina_Bool > > disabled); > > > - EAPI Eina_Bool elm_entry_magnifier_disabled_get(const Evas_Object > > *obj); > > > > Shouldn't that be part of Elementary window config ? As application > > should really not care about that. > > > Yes, and I'd say it should emit some signal or callbacks and be replaceable > from outside of elm. If its possible to have the magnifier usable from > other places (magnify at x,y the object o) it would be helpful as well. > > > > > > Regards, > > -- > > Cedric BAIL > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: [email protected] > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
