you should add that it's compile time of a theme and not edje itself, imo On Fri, Jul 13, 2012 at 4:50 AM, Enlightenment SVN <no-re...@enlightenment.org> wrote: > Log: > edje: warn at compile time about forgotten image. > > NOTE: You need to enable at least Eina_Log warning level > to see them. > > > Author: cedric > Date: 2012-07-12 19:50:58 -0700 (Thu, 12 Jul 2012) > New Revision: 73784 > Trac: http://trac.enlightenment.org/e/changeset/73784 > > Modified: > trunk/edje/ChangeLog trunk/edje/NEWS trunk/edje/src/bin/edje_cc_out.c > trunk/edje/src/lib/edje_calc.c > > Modified: trunk/edje/ChangeLog > =================================================================== > --- trunk/edje/ChangeLog 2012-07-13 00:41:43 UTC (rev 73783) > +++ trunk/edje/ChangeLog 2012-07-13 02:50:58 UTC (rev 73784) > @@ -523,3 +523,7 @@ > * Text classes: Fixed edje_text_class_set to behave like > edje_object_text_class_set (and as expected) wrt NULL fonts. > > +2012-07-12 Cedric Bail > + > + * Warn at compile time about forgotten image definition. > + > > Modified: trunk/edje/NEWS > =================================================================== > --- trunk/edje/NEWS 2012-07-13 00:41:43 UTC (rev 73783) > +++ trunk/edje/NEWS 2012-07-13 02:50:58 UTC (rev 73784) > @@ -11,6 +11,7 @@ > process (Use it to replace RECT part that are never visible and never > catch any event). > * Add accessibility flags and API to retrieve the relevant part. > * Emit signal when flagged part size get to zero. > + * Warn at compile time about forgotten image. > > Improvements: > * Allocate once and reuse Evas_Map. > > Modified: trunk/edje/src/bin/edje_cc_out.c > =================================================================== > --- trunk/edje/src/bin/edje_cc_out.c 2012-07-13 00:41:43 UTC (rev 73783) > +++ trunk/edje/src/bin/edje_cc_out.c 2012-07-13 02:50:58 UTC (rev 73784) > @@ -226,12 +226,11 @@ > { > unsigned int i; > > -#if 0 /* FIXME: This check sounds like not a useful one */ > - if (epd->image.id == -1) > - ERR(ef, "Collection %s(%i): image attributes missing for " > - "part \"%s\", description \"%s\" %f\n", > + /* FIXME: This check sounds like not a useful one */ > + if (epd->image.id == -1 && epd->common.visible) > + WRN("Collection %s(%i): image attributes missing for " > + "part \"%s\", description \"%s\" %f", > pc->part, pc->id, ep->name, epd->common.state.name, > epd->common.state.value); > -#endif > > for (i = 0; i < epd->image.tweens_count; ++i) > { > > Modified: trunk/edje/src/lib/edje_calc.c > =================================================================== > --- trunk/edje/src/lib/edje_calc.c 2012-07-13 00:41:43 UTC (rev 73783) > +++ trunk/edje/src/lib/edje_calc.c 2012-07-13 02:50:58 UTC (rev 73784) > @@ -420,10 +420,10 @@ > { > if (image_num == (image_count - 1)) > { > - image_id = _edje_image_find(ep->object, ed, > - &ep->param2->set, > - (Edje_Part_Description_Image*) > ep->param2->description, > - NULL); > + image_id = _edje_image_find(ep->object, ed, > + &ep->param2->set, > + > (Edje_Part_Description_Image*) ep->param2->description, > + NULL); > } > else > { > @@ -435,11 +435,13 @@ > } > if (image_id < 0) > { > - ERR("¨Part \"%s\" has description, " > - "\"%s\" %3.3f with a missing image id!!!", > + ERR("¨Part \"%s\" description, " > + "\"%s\" %3.3f with image %i index has a missing image id in > a set of %i !!!", > ep->part->name, > ep->param1.description->state.name, > - ep->param1.description->state.value); > + ep->param1.description->state.value, > + image_num, > + image_count); > } > else > { > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
