On Wednesday, July 18, 2012, Carsten Haitzler wrote: > On Tue, 17 Jul 2012 08:42:51 -0300 Gustavo Sverzut Barbieri > <barbi...@profusion.mobi <javascript:;>> said: > > > On Tuesday, July 17, 2012, Enlightenment SVN wrote: > > > > > Log: > > > hell no. printf. not eina-log. this is test exampels, not debug from > > > an app. they printf as OUTPUT. alkso u broke build: > > > > > > /home/raster/C/elm/src/bin/test_genlist.c:2862: undefined reference > to > > > _elm_log_dom' > > > > > > of course there is no symbol exposed that is an INTERNAL LOG DOMAIN > to > > > elm! it's for elm not for outside. > > > > > > > > > > > > Author: raster > > > Date: 2012-07-17 01:42:25 -0700 (Tue, 17 Jul 2012) > > > New Revision: 73957 > > > Trac: http://trac.enlightenment.org/e/changeset/73957 > > > > > > Modified: > > > trunk/elementary/src/bin/test.h > > > > > > Modified: trunk/elementary/src/bin/test.h > > > =================================================================== > > > --- trunk/elementary/src/bin/test.h 2012-07-17 08:34:31 UTC (rev > 73956) > > > +++ trunk/elementary/src/bin/test.h 2012-07-17 08:42:25 UTC (rev > 73957) > > > @@ -18,9 +18,8 @@ > > > } while(0) > > > #endif > > > > > > -extern int _elm_log_dom; > > > -#define CRITICAL(...) EINA_LOG_DOM_CRIT(_elm_log_dom, __VA_ARGS__) > > > -#define ERR(...) EINA_LOG_DOM_ERR (_elm_log_dom, __VA_ARGS__) > > > -#define WRN(...) EINA_LOG_DOM_WARN(_elm_log_dom, __VA_ARGS__) > > > -#define INF(...) EINA_LOG_DOM_INFO(_elm_log_dom, __VA_ARGS__) > > > -#define DBG(...) EINA_LOG_DOM_DBG (_elm_log_dom, __VA_ARGS__) > > > +#define CRITICAL(...) printf(__VA_ARGS__) > > > +#define ERR(...) printf(__VA_ARGS__) > > > +#define WRN(...) printf(__VA_ARGS__) > > > +#define INF(...) printf(__VA_ARGS__) > > > +#define DBG(...) printf(__VA_ARGS__) > > > > > > It will not differentiate messages. Also will miss trailing \n > > what are u differentiating them for? this is being used to do output. nb > the INF > ()'s in test_genlist.c still had \n's and the log domain symbol isn't > exported > by elm. it is silly to use eina_log here. this isn't about having log > domains > and turning things on and off and colorising things. this is basic output. > it > belongs as a printf. i can just see it - you'd argue we should use > eina_log if > we wrote emacs and had to output text. :) > > > Easiest would be to actually create a log domain or use 0 (default log > > domain) or just define these to the macros that use the default log > domain > > (see eina_log.h) > > this is normal output. results of user interactions. it's not logging. it > belongs as a printf.
I agree this could be boring printf. Just the macros would not be compatible if it copes with eina_log that does not need \n > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Live Security Virtual Conference > > > Exclusive live event will cover all the ways today's security and > > > threat landscape has changed and how IT managers can respond. > Discussions > > > will include endpoint security, mobile security and the latest in > malware > > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > _______________________________________________ > > > enlightenment-svn mailing list > > > enlightenment-...@lists.sourceforge.net <javascript:;> <javascript:;> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: barbi...@gmail.com <javascript:;> > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net <javascript:;> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com <javascript:;> > > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
