On Thursday 19 July 2012 17:22:34 Anisse Astier wrote: > Hi, > > Here is some feedback regarding Ecore_exe callback when you want to read > a child process' stdout/stderr. > > - data is data. not a string, except if in buffered mode. It's somehow > in the doc of ecore_exe_pipe_run, but I saw two developers getting > bitten by it. Maybe make that very explicit, because people want to > naturally use that as string. Especially when they look at the > example... > - which example > > http://docs.enlightenment.org/auto/ecore/ecore_exe_example_8c-example.html# > _a0 is in buffered mode, but uses event_data->data instead of > event_data->line[0].data, which is confusing too. And it's a mistake, > because it might miss additionnal lines (which of course does not > apply to the child in this example). > - using event->data as a string in non-buffered mode might work > sometimes if the memory was zeroed before allocation, but this is not > guaranteed. There's probably code out there which works but has this > mistake. > - broken link: > > http://docs.enlightenment.org/auto/ecore/struct__Ecore__Exe__Event__Data.ht > ml link to ecore_exe_example.c has too many underscores This is troubling since I'm fairly sure the link is created by doxygen automatically, but I'll double check. > - missing structure documentation: > > http://docs.enlightenment.org/auto/ecore/struct__Ecore__Exe__Event__Data__L > ine.html#_details > > Regards, > > Anisse
Anisse, Thank you very much for the feedback, I'll look into improving the documentation of Ecore_Exe and make sure those issues are fixed. Look for a fix early next week. Gastal ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
