On Thu, 26 Jul 2012 00:34:40 -0300 Gustavo Sverzut Barbieri <barbi...@profusion.mobi> said:
> On Thursday, July 26, 2012, Carsten Haitzler wrote: > > > On Thu, 26 Jul 2012 00:00:05 -0300 Gustavo Sverzut Barbieri > > <barbi...@profusion.mobi <javascript:;>> said: > > > > > On Wednesday, July 25, 2012, Carsten Haitzler wrote: > > > > > > > On Wed, 25 Jul 2012 20:00:38 -0300 Gustavo Sverzut Barbieri > > > > <barbi...@profusion.mobi <javascript:;> <javascript:;>> said: > > > > > > > > > On Wed, Jul 25, 2012 at 7:42 PM, Enlightenment SVN > > > > > <no-re...@enlightenment.org <javascript:;> <javascript:;>> wrote: > > > > > > Log: > > > > > > segment control: improve test, show broken theme. > > > > > > > > > > > > segment control theme is broken and non-standard. It should be > > like a > > > > > > button in internals. > > > > > > > > > > actually segment control is an incredible mess. Instead of using a > > > > > box, it calculates the positions manually. It also manages the click > > > > > itself based on mouse up/down from evas, not events from theme. > > > > > > > > it also looks ugly - doesn't fit in at all. popup also has issues in > > > > internal > > > > layout/setup. > > > > > > > > > to fix segment control I'd propose rewrite it, but it would break > > > > > theme API to be done properly. What do you say? > > > > > > > > we can't break theme api. we at LEAST have to support the current theme > > > > api and > > > > add a new theme api in addition. this means its not pretty, but thus > > comes > > > > the > > > > price of 1.0 and api stability :) > > > > > > > > > If I cannot change its theme API, very likely I won't touch its C > > > > > internals. Anyone willing to do the hack? I'm not wasting my time > > > > > doing a hack, either I fix or I give up. > > > > > > > > we can't break. sorry :( sucky though it is. > > > > > > > > reality is that segmentcontrol CAN be done with: > > > > > > > > 1. box (horizontal, hommogenous) > > > > 2. radios (with different style for first/last item or for a single > > > > stand-along > > > > item) > > > > > > > > i'd rather just let segmentcontrol stay and then fix up theme to > > recycle > > > > the > > > > elements into radio styles and make an elc thing to replace it and let > > the > > > > old > > > > segmentcontrol stay but be shunned (maybe remove all documentation?). > > > > alternative is to do this internally in segment control and try find > > new > > > > theme > > > > elements firs,t for the redesign - if this fails fallback to the > > current > > > > stuff. > > > > > > > > > Concept and public API of segment control are okay. The internal code is > > > not. The theme is not. > > > > thats my point behind "making the internal code use box+radio... etc." - > > do > > that internally as its simpler and much more "mature", but we need to keep > > the > > current THEME support there - and easiest way is via keeping the same code > > and > > just having the widget "switch early on creation" based on if the theme > > supports the new "namespace" or not. > > > > > Problems with theme: > > > - base does not provide a swallow or box. > > > - item does not emit a signal to notify clicked. > > > - pressed is emitted by application. > > > > > > I'm not sure how to support these, it's a bug and it's better fixed. > > Sorry, > > > people do mistakes, we accepted the buggy code and now we fix it. The > > more > > > we delay to fix, the more people will use and more problems will have. > > > > > > As I said, public API is fine. I'd not consider theme stable at this > > point, > > > ctxpopup and others are also bad enough. Also I expected Tizen to be a > > > valid user, but it's not official and it's patches, theme and usage are > > > complete garbage. No reason why bother about it. > > > > it still is a break in api. the best way is to simply make a new > > segmentcontrol > > bit of code as u sau - new widget, but its "internal" to the current api > > and it > > switches at runtime based on what the theme provides. > > > So what to do? I won't use my scarce time to do this hack. Will someone > else do or we leave it broken? depends on time available and effort, but we can't break things. right now i'm just spending time on things actually broken - not things that are ugly/nasty :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
