Dear Thiep, Thanks a lot for the test case. Obviously, the previous test case was enough, I was asking where I could see the behaviour you are referring to... Then I remembered that Ctrl+Left-Arrow already works so it's easy to test it there.
Anyhow, your patch has a bug in it. i is unsigned so doing ">= 0" is useless (it's always true, please turn on your compiler warnings. -Wall -Wextra) so it'll probably infinitely loop in some cases or just be plain wrong (become very large). Therefore I fixed it a bit differently, and I hope it's cleaner now. I also added a test case to make sure we never get that again. :) Rev: 75595. Enjoy, and please let me know if you experience any other issues. -- Tom. On 23/08/12 03:51, thiep ha wrote: > You can use following test cases: > > 1.1+2.2 > > =3.3 > > (another test case) > > Best Regards, > > Thiep Ha > > ------- *Original Message* ------- > > *Sender* : Tom Hacohen<tom.haco...@samsung.com> Engineer/STRI-EFL > Enhancement/Samsung Electronics > > *Date* : Aug 22, 2012 23:28 (GMT+09:00) > > *Title* : Re: [E-devel] [Patch] [Evas Textblock] Correct the way to > select word > > Do you have a test case we can use to verify? > > -- > Tom. > > On 22/08/12 17:05, thiep ha wrote: > > Dear all, > > > > For current textblock, if the text starts with a word separator > (e.g. =abcdef), we cannot select the text by double click on the text > (e.g. if we double click on abcdef, it will select = character). > > I attached to this email a patch to fix that. > > Please review this patch. > > > > Best Regards, > > Thiep Ha > > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > > > > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
