Hello, On 08/24/2012 02:03 PM, Rajeev Ranjan wrote: > [Root cause]: > Some locales don't have AM/PM string since they strictly follow 24 HR > format and the this case is not handled in datetime widget. > > [Change Description]: > Datetime widget is modified to display default AM/PM strings incase, if, > it is not present in the locale.
Is that still going to display AM/PM even if the hours are in 24h mode? If so I am against this. I quite like my 24h time :-) > + // If a locale doesn't support AM/PM strings, set the default values > + if ((buf[0] == 0) && (!strncmp(fmt, "%p", BUFF_SIZE) || strncmp(fmt, > "%P", BUFF_SIZE))) Here you probably want to negate the second strncmp() as well, so: ... && (!strncmp() || !strncmp()) Regards Daniel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel