On Tue, 4 Sep 2012 09:41:54 +0900 Sungho Kwak <sungho....@gmail.com> said:
actually i think this patch is wrong... do you have any valgrind debug output
for this? the code explicitly tries to handle the case of no cb_return (it
being NULL - ie u dont care about the return value). i don't understand how
this might crash EXCEPT that dbus_connection_send_with_reply() returns true AND
doesn't set pending to some value. this seems odd. then it may be garbage stack.
i made the code more "robust" in commit 76100 but... i still don't see how it
should segv (see above - unless pending is not being set and the send succeeds).
> Hi,
>
> I found that if Callback function was missed, e_dbus_message_send crashed.
> It need some routine for that.
>
> @@ -64,7 +64,9 @@ e_dbus_message_send(E_DBus_Connection *conn, DBusM
> {
> DBusPendingCall *pending;
>
> + EINA_SAFETY_ON_NULL_RETURN_VAL(cb_return, NULL);
> EINA_SAFETY_ON_NULL_RETURN_VAL(conn, NULL);
> +
> if (!dbus_connection_send_with_reply(conn->conn, msg, &pending, timeout))
> return NULL;
>
> I cannot determine do I need to add error message or not :(
> Please advise me.
>
>
>
> Thanks.
> Sincerely,
> Sungho Kwak
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) ras...@rasterman.com
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
