On Mon, 16 Jul 2012 10:50:17 +0000 (GMT) Myung-Jae Lee <mjae....@samsung.com> said:
hooray! time to get back to this feature now after release. i've taken a look and this looks good to me - the code is clean, and does what is needed, but there is a catch. it has a bug. :) when you have an EMPTY line with no text, the cursor moves there on dragging the selection but the selection block doesn't. try elm entry test - see the blank line between: "to refer to them this way." and "Also you can..." drag the end selection handle over this and the cursor goes, but not the handle. also drag the left (or right) handles so they go left of the entry.. if the entry is aligned to the left side of the window the handle becomes invisible. shouldn't the handle "flip" direction to point the handle inwards away from the screen/window edge? :) i know later you have stuff to make handles change between vertical positions, but what about horizontal positions too? one more thing. the handler start/end groups should have swallows where it is possible in elm to provide a swallowed invisible rect that will be set to "finger size" and thus ensure the hit-area of the handler is the right size. :) again - a smallish thing, but necessary for correct sizing. > Dear all EFL developers, > > Following the previous magnifier patch, I'm trying to add another entry > feature, "selection handler" that can help user extend text selection easily > in the mobile envieronment. Current patch only includes the basic operations > of the edje_entry handler objects (create, show, hide, and how to extend the > selection). > > This handler feature can be tested alone without magnifier feature, so I made > selection handler patch only without the previous magnifier patch. (just > based on the latest svn) If there's no problem in this patch, next features > will be added in separate patch files and those will also include magnifier > feature if it's verified to be acceptable in svn until that time. > > Heres are the features to be added soon > - Selection handlers will be shown or hidden whether they are inside the > entry viewport or not > - Support handlers' position changes by edje signal > - Magnifier will be shown while selection handlers are moved If magnifier is > turned on > > > Please review this patch and feel free to give me feedbacks when you have > questions. > > Regards, > -------------- > Myungjae Lee -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
