Ok I changed my mind. Returning NULL would not help users to detect a bug because list can be NULL.
So the first one! Now I am in a 'fix the documentation' mood. Daniel Juyung Seo (SeoZ) On Fri, Sep 7, 2012 at 2:45 PM, Daniel Juyung Seo <seojuyu...@gmail.com> wrote: > Well... > > According to the existing code, it returns 'list' when func is NULL. > According to the documentation, it returns NULL when func is NULL. > > Fighting between code and documentation :) > This is a matter of choice imho. > > I prefer the second one. > > Of course, we should print a huge amount of error messages in either case. > > Daniel Juyung Seo (SeoZ) > > > On Fri, Sep 7, 2012 at 2:13 PM, Sungho Kwak <sungho....@gmail.com> wrote: >> Huh, where is my attached file? :( >> >> 2012/9/7 곽성호 <sungho1.k...@samsung.com> >> >>> Hi, >>> >>> I found 2 bugs on eina_list.c >>> 1) eina_list_sort : if func or list is NULL, function returns NULL (on >>> documentation). I changed code to check to check both of func and list with >>> well-known pattern. >>> 2) eina_list_accessor_new : if list is NULL, function nreturn NULL (on >>> documentation). I add NULL check routine. >>> >>> Thanks. >>> >>> Sincerely, >>> Sungho Kwak. >>> >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
