On 10/06/2012 11:05 PM, Igor Murzov wrote:
>> #3 is definitely correct.
>
> Then could you simplify this part, so that it doesn't look
> like bad copy&paste?
I don't think it looks like bad copy and paste. Think of it as mode
being a primary action, and detail a subsidiary. Then it is nice to nest
them in two levels. Look at _e_border_cb_window_focus_out and see how it
is when there are more cases.
S.
>
>
> -- Igor
>
>> Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov <e-m...@date.by>:
>>
>>> Hi list.
>>>
>>> There are several suspicious code snippets in E, that
>>> look much like copy&paste errors, but I don't know how
>>> to properly fix those errors. Maybe someone experienced
>>> could look into these.
>>>
>>> #1: src/bin/e_backlight.c#n496
>>> ----------------------------------------
>>> if ((e_config->backlight.sysdev) &&
>>> (!strcmp(e_config->backlight.sysdev, f)))
>>> bl_sysval = eina_stringshare_add(f);
>>> else
>>> bl_sysval = eina_stringshare_add(f);
>>> ----------------------------------------
>>>
>>> #2: src/bin/e_gadcon.c#n2988
>>> ----------------------------------------
>>> if (e_gadcon_layout_orientation_get(gc->o_container))
>>> e_gadcon_layout_pack_request_set(o, gcc->config.pos,
>>> gcc->config.size);
>>> else
>>> e_gadcon_layout_pack_request_set(o, gcc->config.pos,
>>> gcc->config.size);
>>> ----------------------------------------
>>>
>>> #3: src/bin/e_border.c#n5765
>>> ----------------------------------------
>>> if (e->mode == ECORE_X_EVENT_MODE_GRAB)
>>> {
>>> if (e->detail == ECORE_X_EVENT_DETAIL_POINTER) return
>>> ECORE_CALLBACK_PASS_ON;
>>> }
>>> else if (e->mode == ECORE_X_EVENT_MODE_UNGRAB)
>>> {
>>> if (e->detail == ECORE_X_EVENT_DETAIL_POINTER) return
>>> ECORE_CALLBACK_PASS_ON;
>>> }
>>> ----------------------------------------
>>>
>>>
>>> -- Igor
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
