On Thu, 4 Oct 2012 16:09:49 -0300 Lucas De Marchi <[email protected]> said:
> On Thu, Oct 4, 2012 at 11:56 AM, Enlightenment SVN > <[email protected]> wrote: > > Log: > > e/connman: Check for the correct messages. > > > > Checking two times the same message does not make any sense. The only > > logical thing seems to be checking for the properties message here. Leaving > > the wifi properties message out as not every setup has wifi. At least on my > > desktop here I don't have /net/connman/technology/wifi so we should not > > fail without it. > > You could put wifi props there. We are just checking if the message > was actually created. > > HOWEVER, handling technologies in this function is totally misplaced. > I blame raster for adding this code :). The intention of this function > was to deal with Manager interface. Right approach would be to create > some infra similar to deal with technologies, calling > GetTechnologies() on Manager, monitoring signals etc. i had to add it... because there was zero way to make my network work at all unless u added at least a toggle checkbox to stop rfkilling everything which is what connman loves to do by default. it was painful as i had to do the work on my 13" laptop screen+kbd so getting it working at all i was happy :) > That said... as it is right now it works, so I'm not changing it. > Soon it will start using edbus, too. > > > > > Dermarchi or Bdilly please cry or fix if this is not as intended. > > (Brought to you by double_condition_check.cocci) > > nice someone is using these scripts... it's a long time since I wrote them > > > > > Author: stefan > > Date: 2012-10-04 07:56:17 -0700 (Thu, 04 Oct 2012) > > New Revision: 77440 > > Trac: http://trac.enlightenment.org/e/changeset/77440 > > > > Modified: > > trunk/e/src/modules/connman/e_connman.c > > > > Modified: trunk/e/src/modules/connman/e_connman.c > > =================================================================== > > --- trunk/e/src/modules/connman/e_connman.c 2012-10-04 14:30:55 UTC > > (rev 77439) +++ trunk/e/src/modules/connman/e_connman.c 2012-10-04 > > 14:56:17 UTC (rev 77440) @@ -910,7 +910,7 @@ > > > > "/net/connman/technology/wifi", > > CONNMAN_TECHNOLOGY_IFACE, > > "GetProperties"); > > - if (!msg_services || !msg_services) > > + if (!msg_services || !msg_props) > > good catch. > > > Lucas De Marchi > > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
