On Tue, 9 Oct 2012 00:44:27 +0900 Bluezery <ohpo...@gmail.com> said:

> 2012/10/5 Enlightenment SVN <no-re...@enlightenment.org>:
> > Log:
> > ecore: let's try another approach thanks to Guillaume Friloux.
> >
> >
> > Author:       cedric
> > Date:         2012-10-05 06:07:14 -0700 (Fri, 05 Oct 2012)
> > New Revision: 77533
> > Trac:         http://trac.enlightenment.org/e/changeset/77533
> >
> > Modified:
> >   trunk/ecore/src/lib/ecore_con/ecore_con_url.c
> >
> > Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c
> > ===================================================================
> > --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c       2012-10-05 12:18:51
> > UTC (rev 77532) +++ trunk/ecore/src/lib/ecore_con/ecore_con_url.c
> > 2012-10-05 13:07:14 UTC (rev 77533) @@ -56,7 +56,7 @@
> >  static int _init_count = 0;
> >  static Ecore_Timer *_curl_timer = NULL;
> >  static Eina_Bool pipelining = EINA_FALSE;
> > -
> > +Ecore_Idler *_curl_idler;
> >  #endif
> >
> >  /**
> > @@ -91,6 +91,7 @@
> >
> >     _curl_timer = ecore_timer_add((double)ms / 1000, _ecore_con_url_timer,
> > NULL); ecore_timer_freeze(_curl_timer);
> > +   _curl_idler = NULL;
> >
> >     return _init_count;
> >  #else
> > @@ -114,6 +115,9 @@
> >          _curl_timer = NULL;
> >       }
> >
> > +   if (_curl_idler) ecore_idler_del(_curl_idler);
> > +   _curl_idler = NULL;
> > +
> >     EINA_LIST_FREE(_url_con_list, url_con)
> >       ecore_con_url_free(url_con);
> >     EINA_LIST_FREE(_fd_hd_list, fd_handler)
> > @@ -1335,7 +1339,7 @@
> >
> >     e->status = status;
> >     e->url_con = url_con;
> > -
> > +
> >     url_con->event_count++;
> >     ecore_event_add(ECORE_CON_EVENT_URL_COMPLETE, e,
> > (Ecore_End_Cb)_ecore_con_event_url_free, url_con); }
> > @@ -1549,6 +1553,9 @@
> >
> >     ecore_timer_interval_set(_curl_timer, (double)ms / 1000);
> >
> > +   if (!_curl_timer)
> > +     _curl_idler = ecore_idler_add(_ecore_con_url_timer, NULL);
> > +
> >     return ECORE_CALLBACK_CANCEL;
> >  }
> >
> Which case can _curl_timer can be NULL in?
> After ecore_con_url_shutdown(), can _ecore_con_url_timer be called?

yeah. cedric typo'd ... i thin it shoulc be if (!_curl_idler) ... add idler. :)
in svn. fixed.


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to