2012/10/13 Carsten Haitzler <ras...@rasterman.com>:
> On Fri, 5 Oct 2012 11:09:12 +0900 Bluezery <ohpo...@gmail.com> said:
>
> that's a pretty big patch for a much smaller set of actual work. reading the
> patch took time because of this (i keep having to compere your new functions
> to
> the old which have like 90% of the same stuff - but they are moved around in
> the file thus unchanged bits becoming part of the patch).
>
> question: why do you not clear (all_free) the cache when block count is set?
> if
> someone sets block count to 4 the item cache will at that point be much bigger
> still.. ?
Previously _item_cache_clean() do not free all caches. it just remove
some caches if current cache size exceeds max cache size.
In my patch, because cache size check is done when cache is pushed and
cache size is always below max size, I just remove that.
> question: item_cache_push seems to want to do more now.. so if nocache_once or
> nocache are set you del the vie obj and spacer THEN you go to item clean which
> now tries to delete signal callbacks from a deleted edje object. this isn't
> very
> nice. :) it should at least check if (VIEW(it)) { ..
> edje_object_signal_del... } there and SET it to NULL on deletion... the only
> thing saving you here is evas's deferred deletion (gcing) of deleted objects
> and magic number checking. this is not something you should depend on. it may
> change in future, and then this code would fall apart nicely :)
Yeah, your're right. NULL check of VIEW(it) is needed.
I currently concentrate on code optimization because I think that
genlist's codes are scattered and hard to be modified.
>
> i fixed the above for you and put in the patch. :) thanks! :)
Thanks very much.
I am fixing map currently and will fix genlist again.
This can be done step by step or big patch. ;)
>
>> I resolved conflicts with recent svn.
>>
>> 2012/10/2 Bluezery <ohpo...@gmail.com>:
>> > Dear EFL developers,
>> >
>> > This is patch for reconstructing genlist's item cache.
>> > Each item cache functions do harsh jobs so just push,pop by Elm_Gen_Item *
>> > now. Before, cache is disabled by comments. But I enabled item cache again
>> > (even for the case which tree_effect_enabled is on).
>> >
>> > I changed some functions:
>> > _item_cache_find() --> _item_cache_pop()
>> > _item_cache_add() --> _item_cache_push()
>> > _item_cache_zero() -->_item_cache_all_free()
>> >
>> > And I removed _item_cache_clean() function because I made
>> > _item_cache_push() to don't exceed the item_cache_max. So clean-up of
>> > cache is not needed anymore.
>> >
>> > I will do more re-factoring jobs for genlist.
>> > Please review this patch.
>> >
>> > --
>> > BRs,
>> > Kim.
>>
>>
>>
>> --
>> BRs,
>> Kim.
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler) ras...@rasterman.com
>
--
BRs,
Kim.
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
