On Mon, 15 Oct 2012 09:07:45 -0300 Gustavo Sverzut Barbieri <barbi...@profusion.mobi> said:
> On Mon, Oct 15, 2012 at 8:19 AM, Carsten Haitzler <ras...@rasterman.com> > wrote: > > On Mon, 15 Oct 2012 19:29:08 +0900 Kim Shinwoo <kimcinoo....@gmail.com> > > said: > > > >> dear all, hello > >> > >> i have learned that someone hates popup. because it does as list. > >> the attached patch makes popup use list. now the popup is really > >> "ELC"_popup. > >> then please review the patch and give feedback. thanks. > > > > here's the nasty bit... this is going to break existing themes as they theme > > popup list items but now they change to look like regular list items :( this > > needs to go along with a whole parallel new bit of internal popup code. the > > old ugly compat stuff there now and a new cleaner impl. the code decides > > based on if you have theme stuff for the new popup or not... or maybe some > > configuration value or env var or something. compatibility with existing > > themes is needed :( > > I didn't read the patch, but the problem with elm_popup was not just > the list, but it replicated lots of other bits. It's very similar to > notify and inwin as well (one could use the other?). yup. it has other problems too. many others. the api is ok - the internals need a gutting. but for compatibility we have to keep the current theme logic as a compat option. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
