I applied bluezery's patch partially. We should fix the focus issue. This can be reproduced easily with elementary_test -> "Genlist Full Widget" test. Scroll the genlist and click any button inside genlist. Genlist will be scrolled to the top.
Thanks. Daniel Juyung Seo (SeoZ) On Wed, Oct 17, 2012 at 11:35 AM, Daniel Juyung Seo <seojuyu...@gmail.com> wrote: > Well this is a big issue. We should fix this first rather than fixing > this in test code. > Glima do you have an idea? > > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Tue, Oct 16, 2012 at 7:57 PM, Bluezery <ohpo...@gmail.com> wrote: >> Dear all, >> >> This is patch for fixing map test application's weird behavior. >> You can see this bug after zooming 3-4 times and clicking right mouse >> button to show elm_menu and click menu item or outside of the menu. >> Map is always moved to 0, 0 axis. >> >> I have found the reason. >> In _elm_widget_focus_region_show() (elm_widget.c), When a widget >> object has scroller interface and children object, scroller is moved >> if children object get focused. I think that this is only for entry >> widget used inside scroller because on_focus_region() is only >> implemented in entry. (entry is focused inside scroller then scroller >> is also moved to show entry.) >> >> This is not for elm_map, elm_genlist, elm_gengrid, etc. Also widget >> implement on_focus_region() but It set x, y as 0, 0. So elm_map is >> moved to 0, 0 when elm_menu (children of map) is focused. >> Actually elm_widget_focus_region_get(obj, &x, &y, &w, &h) for the >> menu object can not give the content position inside parent's >> scroller. Only parent object (has scroller) can know the children >> object's region inside scroller. >> >> I think that this is not for all the case. My solutions are ... >> 1) Scroller movement should not be done for only parent and children >> relation they have. >> Scroller movement is specified such as API something like >> elm_scroller_focus_move_set (map, menu) . >> Only in this case, scroller can be moved. >> >> 2) focus region get interface should be implemented in pan smart >> scroller object. >> So focus region get hook of scroller interface is called when children >> objects get focused. >> And scrollable object calculate children's region to show it. >> >> Anyway, I attach temporary fix for this. >> Please review this patch. >> >> >> BRs, >> Kim. >> >> -- >> BRs, >> Kim. >> >> ------------------------------------------------------------------------------ >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
